Page MenuHome
Differential D9080

Fix T81200: Crash on certain armature select operators when OpenGL Depth Picking is disabled
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 1 2020, 6:24 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T81200: Select linked on armatures crashes when OpenGL Depth Picking is disabled
Commits
rBe3b49bb85001: Fix T81200: Crash on certain armature select operators when OpenGL Depth
Summary

Affected were (at least)

  • Select Linked pick
  • Select Shortest Path

Was originally caused by rB8b347fc2cdc6 [which got improved in
rBfc8a7a44b200 - but only partially].

After removal of BONESEL_NOSEL we have to filter out -1 from the hits for
any bone picking it seems (since armature drawing uses this).
In rBfc8a7a44b200, this was done for 'ED_armature_edit_select_pick' (or
'get_nearest_editbonepoint' precisely), now do this for
'ed_armature_pick_bone_impl' as well.

Diff Detail

Repository
rB Blender
Branch
T81200 (branched from master)
Build Status
Buildable 10523
Build 10523: arc lint + arc unit

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
armature/
12 lines

Diff 29485

View Options

source/blender/editors/armature/armature_select.c

Loading...