Page MenuHome

Rigify: Turn Rotation Mode converter into single operator
ClosedPublic

Authored by Demeter Dzadik (Mets) on Oct 2 2020, 6:09 PM.

Details

Summary

This operator used to demand a huge chunk for itself as the sole inhabitant of the Rigify panel in the sidebar with a bunch of options that are only relevant when the operator is actually ran. Also for some reason it was split up to two separate operators for the sake of having "convert all actions" vs "convert current action" buttons.

So, I removed that UI from the sidebar entirely, turned all the options into parameters on a SINGLE operator which asks for those options when ran using invoke() and draw(). This operator now lives in the Pose drop-down menu, which is where you would expect to find it. This is also searchable with the new search menu, unlike the sidebar.

Also note that this operator has precisely nothing to do with Rigify, and should be a separate addon. I would split it out in a separate patch.

Diff Detail

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Oct 2 2020, 6:09 PM
Demeter Dzadik (Mets) created this revision.

Remove unused functions

Seems reasonable. Yes, this seems more suitable as a separate addon - it seems it was one originally anyway.

This revision is now accepted and ready to land.Oct 19 2020, 3:27 PM

Can we have this operator in a button here:

Otherwise how do we expect animators to ever discover it even exists?, the fact that it was an addon part of rigify made it already super undiscoverable and its a really important feature for animation

I think if this was split out into a separate addon, it could be made more discoverable because then that addon could have the "Location" entry say View3D -> Pose -> Convert Rotation Modes. I would gladly do this sometime.

It can be found with menu search also. The whole problem with putting operators in the side bar is that it won't be found by the search. But also, right clicking on the Transform drop-down and clicking on Edit Source doesn't work, so I'm guessing this piece of the UI is implemented in C for some reason? So I think we couldn't add to it there even if we wanted to. And even if we could, only at the bottom, not right next to Rotation Mode where you would expect it.