Page MenuHome

Fix critical bug in libmv after rB3a7d62cd1f5e
ClosedPublic

Authored by Bastien Montagne (mont29) on Oct 3 2020, 5:50 PM.

Details

Summary

Current libmv_modal_solver_test fails since rB3a7d62cd1f5e.

It appears that the issue is caused by the insertion of the new OFFSET_K4 parameter, as if camera intrinsics are not required to implement/use all of those deform parameters, they absolutely have to keep order (values) matching those defined in bundle.cc, otherwise PackIntrinisicsIntoArray and UnpackIntrinsicsFromArray mangle them around.

At least that is my understanding of the issue, and this patch seems to fix the test.

Diff Detail

Repository
rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Oct 3 2020, 5:50 PM
Bastien Montagne (mont29) updated this revision to Diff 29552.
Bastien Montagne (mont29) created this revision.

Tweak a comment

This revision is now accepted and ready to land.Oct 5 2020, 11:41 AM

Get context in diff...

Bastien Montagne (mont29) closed this revision.EditedOct 5 2020, 12:04 PM

Committed as rB7e836bde11ce, thanks.