Page MenuHome
Differential D9106

Sculpt: Preview the active side of the line gestures
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 4 2020, 9:52 PM.
Tags
None
Subscribers
None
Tokens
"Pterodactyl" token, awarded by shader."Love" token, awarded by zeauro."Love" token, awarded by manitwo."Like" token, awarded by erickblender."Love" token, awarded by gilberto_rodrigues."Party Time" token, awarded by lopoIsaac."100" token, awarded by Frozen_Death_Knight."Mountain of Wealth" token, awarded by Brandon777."Like" token, awarded by TheRedWaxPolice.

Details

Reviewers
Daniel Bystedt (dbystedt)
Julian Eisel (Severin)
Commits
rB628dc91c485a: Sculpt: Preview the active side of the line gestures
Summary

This adds a small gradient to the right side of the line to preview
which side of the mesh is going to be affected by the gesture operation.

Diff Detail

Repository
rB Blender
Branch
wm-line-gesture-side-preview (branched from master)
Build Status
Buildable 10559
Build 10559: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 4 2020, 9:52 PM
Harbormaster completed remote builds in B10559: Diff 29569.Oct 4 2020, 9:52 PM
Pablo Dobarro (pablodp606) requested review of this revision.Oct 4 2020, 9:52 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 4 2020, 9:53 PM
Pablo Dobarro (pablodp606) added reviewers: Daniel Bystedt (dbystedt), Julian Eisel (Severin).
TheRedWaxPolice (TheRedWaxPolice) awarded a token.Oct 4 2020, 9:57 PM
Brandon (Brandon777) awarded a token.Oct 4 2020, 10:22 PM
Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 4 2020, 10:54 PM
Lopo Isaac (lopoIsaac) awarded a token.Oct 4 2020, 11:16 PM
Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Oct 4 2020, 11:22 PM
Erick Tukuniata (erickblender) awarded a token.Oct 4 2020, 11:41 PM
Manuel Grad (manitwo) awarded a token.Oct 5 2020, 9:21 AM
ronan ducluzeau (zeauro) awarded a token.Oct 5 2020, 10:16 AM
Julian Eisel (Severin) requested changes to this revision.Oct 5 2020, 1:02 PM

Overall fine, but found two smaller issues.

source/blender/windowmanager/intern/wm_gesture.c
211

This must be multiplied by U.pixelsize, otherwise the gradient has half the size on hiDPI screens (confirmed with a retina screen).

278–280

Isn't this drawn on top of the line now, darkening the white dashes?

This revision now requires changes to proceed.Oct 5 2020, 1:02 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 29597.Oct 5 2020, 5:19 PM
Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • review update
Harbormaster completed remote builds in B10567: Diff 29597.Oct 5 2020, 5:19 PM
Julian Eisel (Severin) accepted this revision.Oct 5 2020, 5:24 PM
This revision is now accepted and ready to land.Oct 5 2020, 5:24 PM
Closed by commit rB628dc91c485a: Sculpt: Preview the active side of the line gestures (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 5 2020, 7:35 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB628dc91c485a: Sculpt: Preview the active side of the line gestures.
Bataev Artem (shader) awarded a token.Oct 14 2020, 9:00 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
4 lines
windowmanager/
3 lines
2 lines
intern/
51 lines
11 lines

Diff 29569

View Options

source/blender/editors/sculpt_paint/paint_mask.c

Loading...
View Options

source/blender/windowmanager/WM_api.h

Loading...
View Options

source/blender/windowmanager/WM_types.h

Loading...
View Options

source/blender/windowmanager/intern/wm_gesture.c

Loading...
View Options

source/blender/windowmanager/intern/wm_gesture_ops.c

Loading...