Differential D9112

Fix T81380: Playback set start/endframe operators can set negative rendering range
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 5 2020, 4:03 PM.

Tags

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)
Brecht Van Lommel (brecht)

Maniphest Tasks

T81380: Playback set start/end operators can set rendering range fields to negative frames

Commits

rBca38bce46aa2: Fix T81380: Playback set start/endframe operators can set negative

Summary

The Allow Negative Frames option, introduced in rB21a2350248fd, allows
for negative frames, but this should only apply for playback and
animations, the rendering range should still be clamped to MINFRAME /
MAXFRAME, because rendering does not allow for negative frames. Preview
range should not be affected afaict (I am not aware of operators that
allow for rendering this range).

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 5 2020, 4:03 PM

Harbormaster completed remote builds in B10563: Diff 29589.Oct 5 2020, 4:03 PM

Philipp Oeser (lichtwerk) requested review of this revision.Oct 5 2020, 4:03 PM

Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface, Render Pipeline.Oct 5 2020, 4:05 PM

Philipp Oeser (lichtwerk) added reviewers: Sybren A. Stüvel (sybren), Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) accepted this revision.Oct 5 2020, 5:42 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/editors/animation/anim_ops.c
323	Startframe -> Start frame
378	Endframe -> End frame

This revision is now accepted and ready to land.Oct 5 2020, 5:42 PM

Closed by commit rBca38bce46aa2: Fix T81380: Playback set start/endframe operators can set negative (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 5 2020, 6:46 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBca38bce46aa2: Fix T81380: Playback set start/endframe operators can set negative.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

animation/

19 lines

Diff 29602

source/blender/editors/animation/anim_ops.c

Loading...