Page MenuHome

Cleanup: CMake/Draco: Use existing function to add library
AbandonedPublic

Authored by Ankit Meel (ankitm) on Oct 5 2020, 4:36 PM.

Details

Summary

In D4501#102244 brecht wrote

If it's not too complex, we would prefer the CMakeLists.txt that
compiles draco itself to be a custom one that use Blender
functions like blender_add_lib. An example of this is in
extern/glog/CMakeLists.txt.

The reason is that we want all libraries to compiled with the
same compiler flags, debug options and so on. If there is a
draco project embedded in the blender project with its own
mechanism it's harder for us to ensure it works as we need
it on all platforms.

Diff Detail

Repository
rB Blender

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Oct 5 2020, 4:36 PM
Ankit Meel (ankitm) updated this revision to Diff 29592.
Ankit Meel (ankitm) created this revision.

remove extra line

Ankit Meel (ankitm) retitled this revision from CMake/Draco: Use existing macro for adding library to Cleanup: CMake/Draco: Use existing function to add library.Oct 5 2020, 4:42 PM
Brecht Van Lommel (brecht) requested changes to this revision.Oct 5 2020, 4:47 PM

This makes draco no longer shared library, which is needed for Python to import it.

This revision now requires changes to proceed.Oct 5 2020, 4:47 PM

I don't think it's worth trying to change anything here, unless there is a specific reason behind this patch besides trying to simplify the code.

I was experimenting with some linker flags, and this library failed to link. Nothing urgent right now.