Sculpt: Add angle snapping to line gesture tools
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 5 2020, 9:06 PM.

Details

Reviewers

Commits

rB14d56b4217f8: UI: Add angle snapping to line gesture tools

Summary

This adds support for snapping for line gesture tool. It is implemented
in the modal keymap as Snap, which is a toggle (similar to how snapping
in the transform operator works).

Right now it snaps the angle of the line to 45 degree increments, which
is defined in code. This should be easy to expose in the UI in the future
if we need to

Diff Detail

Repository

rB Blender

Branch

line-gesture-angle-snap (branched from master)

Build Status

Buildable 10574
Build 10574: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 5 2020, 9:06 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B10574: Diff 29612.Oct 5 2020, 9:06 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 5 2020, 9:07 PM

Pablo Dobarro (pablodp606) added a reviewer: Julian Eisel (Severin).

it snaps the angle of the line to 45 degree increments, which
is defined in code. This should be easy to expose in the UI in the future
if we need to

Yes please. Or at least make it 5 degree by default in sculpt mode. 45 is not very pratical.

ThinkingPolygons (ThinkingPolygons) awarded a token.Oct 5 2020, 9:19 PM

TheRedWaxPolice (TheRedWaxPolice) awarded a token.Oct 5 2020, 9:28 PM

Lopo Isaac (lopoIsaac) awarded a token.Oct 5 2020, 9:55 PM

Brandon (Brandon777) awarded a token.Oct 5 2020, 10:15 PM

Holding shift should limit the rotation to 5 degree difference

See https://docs.blender.org/manual/en/dev/scene_layout/object/editing/transform/control/precision.html#rotation

For ultra precision the user can also type in an exact angle to cut at

Nelson (NAS) awarded a token.Oct 6 2020, 6:03 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 6 2020, 9:02 PM

In D9115#224804, @Aaron Carlisle (Blendify) wrote:

Holding shift should limit the rotation to 5 degree difference

This is how this patch is working right now?

See https://docs.blender.org/manual/en/dev/scene_layout/object/editing/transform/control/precision.html#rotation

That link says ctrl for 5 degrees 🤔

and shift for very fine control 🤔

LGTM, but indeed, 45° doesn't seem too practical. 10° and 1° for ⇧ seems more appropriate.
Don't think we should add an option for this, I don't think we have a similar one and we can just have good defaults.

This revision is now accepted and ready to land.Oct 15 2020, 10:35 PM

In D9115#228023, @Julian Eisel (Severin) wrote:

Don't think we should add an option for this, I don't think we have a similar one and we can just have good defaults.

Why not? I mean, among the most used 3d apps, blender is the only one that don't expose that setting, why is that? This is a crucial setting of any type of transform tools. Blender really needs it.
Maybe not now, but you guys really should consider adding it soon.

@Julian Eisel (Severin) 10 will prevent snapping to 45, which I think is also quite common. Maybe 5 as a default?

agung andre (g.ndre) awarded a token.Oct 16 2020, 3:34 AM

i think 15 and 5 are the most used intervals.. if this helps

5 it is! 👌

Torrent (Torrent) awarded a token.Oct 19 2020, 4:02 AM

Closed by commit rB14d56b4217f8: UI: Add angle snapping to line gesture tools (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 20 2020, 10:53 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB14d56b4217f8: UI: Add angle snapping to line gesture tools.

Metin Seven (MetinSeven) awarded a token.Oct 21 2020, 7:56 AM