Paths

Table of Contentst

Differential D9123

Storage migration clean up: dropping storage_location fields
ClosedPublic
Actions

Authored by Anna Sirota (railla) on Oct 6 2020, 2:06 PM.

Tags

Subscribers

None

Details

Reviewers

Francesco Siddi (fsiddi)

Commits

rBLSea878e9d5223: Storage migration clean up: dropping storage_location fields

Summary

This change removes unused storage_location fields and drops their columns from the database:

$ ./manage.py migrate --plan
Planned operations:
blog.0006_remove_storage_location_fields
    Remove field storage_location from revision
films.0035_remove_storage_location_fields
    Remove field storage_location from collection
    Remove field storage_location from film
    Remove field storage_location from productionlog
static_assets.0020_remove_storage_location_fields
    Remove field storage_location from staticasset
training.0025_remove_storage_location_fields
    Remove field storage_location from asset
    Remove field storage_location from training
    Remove field storage_location from video

See https://developer.blender.org/T81483 for more details.

Diff Detail

Repository: rBLS Blender Studio

Event Timeline

Anna Sirota (railla) requested review of this revision.Oct 6 2020, 2:06 PM

Anna Sirota (railla) created this revision.

Anna Sirota (railla) mentioned this in T81483: Storage migration: Clean-up.

Anna Sirota (railla) updated this revision to Diff 29833.Oct 12 2020, 11:51 AM

Anna Sirota (railla) added inline comments.Oct 12 2020, 11:56 AM

blog/migrations/0001_initial.py
96	Without `storage_location` being nullable it's not possible to downgrade this migration at all, this at least allows downgrade to run without raising integrity errors. (this obviously doesn't make this change revertable, because `storage_location` values are lost nonetheless)

Anna Sirota (railla) added a reviewer: Francesco Siddi (fsiddi).Oct 12 2020, 11:56 AM

I'm fine with this, especially with the previous agreement that before going to production we will reset all migrations.

This revision is now accepted and ready to land.Oct 12 2020, 3:35 PM

Closed by commit rBLSea878e9d5223: Storage migration clean up: dropping storage_location fields (authored by Anna Sirota (railla)). · Explain WhyOct 12 2020, 3:40 PM

This revision was automatically updated to reflect the committed changes.

Anna Sirota (railla) added a commit: rBLSea878e9d5223: Storage migration clean up: dropping storage_location fields.

Revision Contents
Changeset List

Path

Size

blog/

1 line

16 lines

migrations/

0001_initial.py

1 line

0006_remove_storage_location_fields.py

17 lines

4 lines

1 line

common/

2 lines

tests/

factories/

1 line

13 lines

static_assets.py

11 lines

6 lines

films/

migrations/

0002_film_storage.py

1 line

0013_collections_storage_backend.py

2 lines

0015_squashed_0019_production_log_models.py

2 lines

0021_production_log_alter_fields.py

1 line

0022_storage_on_delete_protect.py

2 lines

0035_remove_storage_location_fields.py

25 lines

models/

4 lines

4 lines

production_logs.py

4 lines

views/

api/

2 lines

1 line

1 line

search/

tests/

test_signals.py

3 lines

static_assets/

1 line

migrations/

0014_storage_on_delete_protect.py

2 lines

0020_remove_storage_location_fields.py

17 lines

models/

static_assets.py

5 lines

training/

management/

commands/

import_legacy_cloud_training.py

10 lines

migrations/

0007_training_storage.py

2 lines

0012_add_storage_backend.py

4 lines

0017_storage_on_delete_protect_and_size_bytes.py

4 lines

0025_remove_storage_location_fields.py

25 lines

models/

7 lines

3 lines

Diff 29842

blog/admin.py

Loading...

blog/forms.py

Loading...

blog/migrations/0001_initial.py

Loading...

blog/migrations/0006_remove_storage_location_fields.py

Loading...

blog/models.py

Loading...

blog/queries.py

Loading...

common/queries.py

Loading...

common/tests/factories/blog.py

Loading...

common/tests/factories/films.py

Loading...

common/tests/factories/static_assets.py

Loading...

common/tests/factories/training.py

Loading...

films/migrations/0002_film_storage.py

Loading...

films/migrations/0013_collections_storage_backend.py

Loading...

films/migrations/0015_squashed_0019_production_log_models.py

Loading...

films/migrations/0021_production_log_alter_fields.py

Loading...

films/migrations/0022_storage_on_delete_protect.py

Loading...

films/migrations/0035_remove_storage_location_fields.py

Loading...

films/models/collections.py

Loading...

films/models/films.py

Loading...

films/models/production_logs.py

Loading...

films/views/api/asset.py

Loading...

films/views/film.py

Loading...

films/views/gallery.py

Loading...

search/tests/test_signals.py

Loading...

static_assets/admin.py

Loading...

static_assets/migrations/0014_storage_on_delete_protect.py

Loading...

static_assets/migrations/0020_remove_storage_location_fields.py

Loading...

static_assets/models/static_assets.py

Loading...

training/management/commands/import_legacy_cloud_training.py

Loading...

training/migrations/0007_training_storage.py

Loading...

training/migrations/0012_add_storage_backend.py

Loading...

training/migrations/0017_storage_on_delete_protect_and_size_bytes.py

Loading...

training/migrations/0025_remove_storage_location_fields.py

Loading...

training/models/sections.py

Loading...

training/models/trainings.py

Loading...