Fix T81488: Deleting an Object Constraint crashes Blender
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Oct 6 2020, 5:41 PM.

Details

Reviewers

Philipp Oeser (lichtwerk)

Maniphest Tasks

T81488: Deleting an Object Constraint crashes Blender

Commits

rB43ceea30f11e: Fix T81488: Deleting an Object Constraint crashes Blender

Summary

The edit_constraint_property_get function was using bone constraints
in pose mode even for object constraints. This change mirrors the code
in`uiTemplateConstraints` as well.

Diff Detail

Repository

rB Blender

Branch

fix-remove-object-constraint-crash (branched from master)

Build Status

Buildable 10590
Build 10590: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Oct 6 2020, 5:41 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B10590: Diff 29643.Oct 6 2020, 5:41 PM

Hans Goudey (HooglyBoogly) added a reviewer: Philipp Oeser (lichtwerk).Oct 6 2020, 5:42 PM

Hans Goudey (HooglyBoogly) added a task: T81488: Deleting an Object Constraint crashes Blender.

Urgh, rB9dcae4eb17d7: Refactor getting constraints was really poop :/

This revision is now accepted and ready to land.Oct 6 2020, 6:38 PM

Closed by commit rB43ceea30f11e: Fix T81488: Deleting an Object Constraint crashes Blender (authored by Hans Goudey (HooglyBoogly)). · Explain WhyOct 6 2020, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB43ceea30f11e: Fix T81488: Deleting an Object Constraint crashes Blender.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

object/

object_constraint.c

2 lines

Diff 29643

View Options

source/blender/editors/object/object_constraint.c

Fix T81488: Deleting an Object Constraint crashes BlenderClosedPublicActions