Page MenuHome

Sculpt: Use cursor depth in trimming gestures
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Oct 6 2020, 7:08 PM.
Tokens
"100" token, awarded by MetinSeven."Love" token, awarded by dbystedt."Love" token, awarded by sick."Love" token, awarded by julperado."Like" token, awarded by JulienKaspar."Love" token, awarded by Anubis."Love" token, awarded by Brandon777."Like" token, awarded by Frozen_Death_Knight."Love" token, awarded by tiagoffcruz.

Details

Summary

This adds an operator property to use the paint cursor radius and
position for the depth of the trimming shape created by the trimming
tools.
When enabled, the shape is located in the surface point when the gesture
started and it will have the depth of the cursor radius. When the cursor
is not over the mesh, the shape will be positioned at the center of the
depth of the whole object from the viewport camera.

This depends on the UI decision of D9071

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 6 2020, 7:08 PM

Wonderful addition! This will improve concept sculpting a whole lot. I'm all for committing this to master

This revision is now accepted and ready to land.Oct 10 2020, 5:11 PM

From the code side seems fine. See the inlined comment, that part seems to be related to an independent fix related on correct order of bounding box corners.

The interface please figure out with the UI team.

source/blender/editors/sculpt_paint/paint_mask.c
440–447

Is this a fix which is unrelated to the new functionality (meaning, it can be done separately)?

This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) marked an inline comment as done.
source/blender/editors/sculpt_paint/paint_mask.c
440–447

No, this change was unrelated. It was left there from a different attempt to implement this.

I'm all for this addition, but I feel like the depth could be visualized better so there's less guesswork - similar to the cursor for the layer brush

Been trying to figure out the tool for awhile now. My brain translated "Cursor" to mean "3D Cursor". I assumed, like the grease pencil tool, the 3D cursor was somehow affecting it's depth, but obviously was not having any luck with that.
I finally realised my misunderstanding (with help from a 3rd party), that the tip is referring to the *painting cursor*.
However, my confusion remained, as I was still thinking in terms of position.
(yes, yes, I know... silly me, but hopefully the train of thought makes sense of my confusion)

Recommend changing the wording.

Instead of:

Use Cursor as Depth

Perhaps:

Cursor Size as Depth

or

Cursor Radius as Depth