Page MenuHome
Differential D9134

Add can_have_animation_data to IDTypeInfo.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Oct 7 2020, 11:41 AM.

Details

Reviewers
Bastien Montagne (mont29)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T75724: Extensible Architecture Refactoring
Commits
rB65a6caafce9f: IDTypeInfo: add flag to indicate that ID has no animation data
Summary

The goal here is to reduce the number of places where we have to check for specific ID types.

Ref T75724.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 7 2020, 11:41 AM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B10597: Diff 29673.Oct 7 2020, 11:42 AM
Jacques Lucke (JacquesLucke) retitled this revision from Cleanup: move `can_have_animation_data` to `IDTypeInfo` to Add can_have_animation_data to IDTypeInfo..Oct 7 2020, 11:42 AM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added reviewers: Bastien Montagne (mont29), Sybren A. Stüvel (sybren).Oct 7 2020, 11:44 AM
Bastien Montagne (mont29) requested changes to this revision.Oct 7 2020, 11:52 AM

Any reason not to use already existing flags here? Like adding new IDTYPE_FLAGS_NO_ANIMDATA, which also has the benefit of not needing any changes for the most common cases (i.e. ID that can have animdata)…

This revision now requires changes to proceed.Oct 7 2020, 11:52 AM
Jacques Lucke (JacquesLucke) added a comment.Oct 7 2020, 11:56 AM
In D9134#225311, @Bastien Montagne (mont29) wrote:

Any reason not to use already existing flags here? Like adding new IDTYPE_FLAGS_NO_ANIMDATA, which also has the benefit of not needing any changes for the most common cases (i.e. ID that can have animdata)…

Good point. Will change that.

Jacques Lucke (JacquesLucke) updated this revision to Diff 29674.Oct 7 2020, 12:06 PM
  • use flag
Harbormaster completed remote builds in B10598: Diff 29674.Oct 7 2020, 12:06 PM
Bastien Montagne (mont29) accepted this revision.Oct 7 2020, 12:27 PM
This revision is now accepted and ready to land.Oct 7 2020, 12:27 PM
Closed by commit rB65a6caafce9f: IDTypeInfo: add flag to indicate that ID has no animation data (authored by Jacques Lucke (JacquesLucke)). · Explain WhyOct 7 2020, 12:38 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB65a6caafce9f: IDTypeInfo: add flag to indicate that ID has no animation data.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
intern/
2 lines
40 lines
2 lines
2 lines
2 lines
2 lines
3 lines
3 lines
4 lines
2 lines
2 lines
2 lines
2 lines
windowmanager/
intern/
3 lines

Diff 29677

View Options

source/blender/blenkernel/BKE_idtype.h

Loading...
View Options

source/blender/blenkernel/intern/action.c

Loading...
View Options

source/blender/blenkernel/intern/anim_data.c

Loading...
View Options

source/blender/blenkernel/intern/brush.c

Loading...
View Options

source/blender/blenkernel/intern/collection.c

Loading...
View Options

source/blender/blenkernel/intern/font.c

Loading...
View Options

source/blender/blenkernel/intern/image.c

Loading...
View Options

source/blender/blenkernel/intern/ipo.c

Loading...
View Options

source/blender/blenkernel/intern/library.c

Loading...
View Options

source/blender/blenkernel/intern/paint.c

Loading...
View Options

source/blender/blenkernel/intern/screen.c

Loading...
View Options

source/blender/blenkernel/intern/sound.c

Loading...
View Options

source/blender/blenkernel/intern/text.c

Loading...
View Options

source/blender/blenkernel/intern/workspace.c

Loading...
View Options

source/blender/windowmanager/intern/wm.c

Loading...