Details

Reviewers

Brecht Van Lommel (brecht)
Simon Thommes (simonthommes)

Commits

rBf7832b1583cd: Volumes: new Volume to Mesh modifier

Summary

This adds a new mesh modifier that converts another volume object into a mesh.
It's doing the opposite of the Mesh to Volume modifier.

I'm not sure what other settings this modifier needs. Maybe you should be able to control the resolution? Currently the resolution is based on the grid resolution.

Diff Detail

Repository

rB Blender

Branch

volume-to-mesh-modifier (branched from master)

Build Status

Buildable 10662
Build 10662: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 7 2020, 6:39 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B10612: Diff 29713.Oct 7 2020, 6:39 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Oct 7 2020, 6:43 PM

Jacques Lucke (JacquesLucke) added reviewers: Brecht Van Lommel (brecht), Simon Thommes (simonthommes).

That's a cool demo video.

I think using the grid resolution is a good default. An option to manually specify the resolution also makes sense to me.

This could get options matching the Remesh modifier in Voxel mode? Basically voxel size (if not chosen to be set automatically), adaptivity and smooth shading.

Maybe we need a more user-friendly name for Iso Value? Not sure if there is a standard term.

Benjamin Sauder (kioku) awarded a token.Oct 7 2020, 8:58 PM

RedMser (RedMser) added a subscriber: RedMser (RedMser).Oct 7 2020, 9:03 PM

Julian Perez (julperado) awarded a token.Oct 7 2020, 9:56 PM

Andres Stephens (Draise) awarded a token.Oct 7 2020, 10:59 PM

Absolutely beautiful.

Jacques Lucke (JacquesLucke) mentioned this in D9151: Parallelize BKE_mesh_calc_edges..Oct 8 2020, 4:51 PM

Jacques Lucke (JacquesLucke) mentioned this in rB309c919ee97e: BKE: parallelize BKE_mesh_calc_edges.Oct 9 2020, 11:59 AM

add adaptivity option
add smooth shading option
add three resolution modes: grid, voxel amount, voxel size

Still have to do some cleanup and figure out why object.imat is not affine in some cases.
This floating point issue makes openvdb throw an exception.

Harbormaster completed remote builds in B10662: Diff 29799.Oct 9 2020, 5:51 PM

Kenzie (kenziemac130) awarded a token.Oct 12 2020, 5:04 AM

Robert Windefjord (Robonnet) awarded a token.Oct 12 2020, 12:36 PM

I just gave it a run, had to try it. Absolutely fantastic!

Having three overlapping objects with two different modifier stacks for this one setup is starting to get a bit crazy for selecting or tweaking things, but that is just how it is for now.
Only additional potential feature that comes to mind would be to remove disconnected single voxels before conversion, but that can also be substituted with mesh modifiers.

Small thing:
Maybe Iso = 0 should not be allowed or clamped?

Simon Thommes (simonthommes) awarded a token.Oct 12 2020, 9:13 PM

RAM (CrossmindStudio) added a subscriber: RAM (CrossmindStudio).Oct 13 2020, 1:50 PM

This comment was removed by RAM (CrossmindStudio).

change soft minimum of iso value
remove timers

Harbormaster completed remote builds in B10710: Diff 29894.Oct 13 2020, 4:28 PM

Only additional potential feature that comes to mind would be to remove disconnected single voxels before conversion, but that can also be substituted with mesh modifiers.

That sounds useful. I'd probably implement this on the mesh level. For example, by removing all connected mesh components with less than x vertices. Not sure if it should be part of this modifier.
In a node setup it would probably be a separate node.

Implementation looks fine to me, only suggestion is to make theiso value name more user friendly.