Use target to refer to bf_draw
Needs ReviewPublic
Actions

Authored by Andreas Bergmeier (abergmeier) on Oct 8 2020, 6:16 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Ray Molenkamp (LazyDodo)

Summary

Remove hardcoded paths to bf_draw includes.
Use CMake target mechanism, these things get automatically applied when using target_link_libraries.
For bf_draw it was sufficient to import properties from bf_draw target to compilation units only (AKA PRIVATE).

Change as a continuation of https://developer.blender.org/D8864

Diff Detail

Event Timeline

Andreas Bergmeier (abergmeier) requested review of this revision.Oct 8 2020, 6:16 PM

Andreas Bergmeier (abergmeier) created this revision.

Please wait until D8864 has landed and then follow the structure it uses.

This revision now requires changes to proceed.Oct 8 2020, 6:20 PM

Ankit Meel (ankitm) added a parent revision: D8864: CMake: Use Modern CMake for clog and guardedalloc.Oct 8 2020, 6:27 PM

Andreas Bergmeier (abergmeier) updated this revision to Diff 29760.Oct 8 2020, 9:41 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

Use target to refer to bf_drawNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29760

source/blender/blenkernel/CMakeLists.txt

source/blender/blenloader/CMakeLists.txt

source/blender/depsgraph/CMakeLists.txt

source/blender/draw/CMakeLists.txt

source/blender/editors/gizmo_library/CMakeLists.txt

source/blender/editors/interface/CMakeLists.txt

source/blender/editors/mesh/CMakeLists.txt

source/blender/editors/render/CMakeLists.txt

source/blender/editors/sculpt_paint/CMakeLists.txt

source/blender/editors/space_image/CMakeLists.txt

source/blender/editors/space_view3d/CMakeLists.txt

source/blender/gpu/CMakeLists.txt

source/blender/makesrna/intern/CMakeLists.txt

source/blender/render/CMakeLists.txt

source/blender/windowmanager/CMakeLists.txt

Use target to refer to bf_draw
Needs ReviewPublic
Actions

Revision Contents
Changeset List