Details

Reviewers

Pablo Dobarro (pablodp606)
Jeroen Bakker (jbakker)

Group Reviewers

Sculpt, Paint & Texture

Maniphest Tasks

T81616: Sculpt Mode - Radius uses wrong units in pop-up menu

Commits

rB3b16530aa13e: UI: Fix incoherent brush size in popover menu and brush settings

Summary

Previously, the popover menu in sculpt/texture paint mode did not
take into account the UnifiedBrushSettings for the unit.

To fix this, the behavior of class _draw_tool_settings_context_mode is matched
by checking the same conditions when setting up the UI of the right-click popover menu.

Fixes T81616

Diff Detail

Repository: rB Blender

Event Timeline

Octave C (toctave) requested review of this revision.Oct 11 2020, 12:26 PM

Octave C (toctave) created this revision.

Harbormaster completed remote builds in B10671: Diff 29814.Oct 11 2020, 12:26 PM

Octave C (toctave) added a reviewer: Sculpt, Paint & Texture.Oct 11 2020, 12:27 PM

Octave C (toctave) retitled this revision from fix T81616 : coherent brush size in popover menu and brush settings to fix T81616 : Coherent brush size in popover menu and brush settings.Oct 11 2020, 12:35 PM

Octave C (toctave) edited the summary of this revision. (Show Details)

Octave C (toctave) edited the summary of this revision. (Show Details)Oct 11 2020, 1:15 PM

Octave C (toctave) added a subscriber: Sculpt, Paint & Texture.Oct 15 2020, 12:08 PM

I leave the patch review to @Pablo Dobarro (pablodp606) on this topic

Pablo Dobarro (pablodp606) accepted this revision.Oct 20 2020, 4:19 PM

This revision is now accepted and ready to land.Oct 20 2020, 4:19 PM

Philipp Oeser (lichtwerk) added a task: T81616: Sculpt Mode - Radius uses wrong units in pop-up menu.Nov 6 2020, 6:00 PM

@Octave C (toctave) : do you have commit access?

@Philipp Oeser (lichtwerk) No I don't.

Aaron Carlisle (Blendify) retitled this revision from fix T81616 : Coherent brush size in popover menu and brush settings to Coherent brush size in popover menu and brush settings.Mar 13 2022, 10:44 PM

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)

Aaron Carlisle (Blendify) retitled this revision from Coherent brush size in popover menu and brush settings to UI: Fix incoherent brush size in popover menu and brush settings.

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)

Closed by commit rB3b16530aa13e: UI: Fix incoherent brush size in popover menu and brush settings (authored by Octave C (toctave), committed by Aaron Carlisle (Blendify)). · Explain WhyMar 13 2022, 10:46 PM

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rB3b16530aa13e: UI: Fix incoherent brush size in popover menu and brush settings.