Page MenuHome

Sculpt: Add global automasking settings support in filters
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Oct 11 2020, 7:29 PM.

Details

Summary

When using the sculpt filters, global automasking settings that affect
all brushes were ignored because the automasking system was not
implemented for filters, making filters and brushes react differently
to the global sculpt settings which creates confusion.

This makes all filter tools (mesh, cloth, color) use the same general
automasking settings and features as the brush tools. Filters will now
use the settings in the options panel to limit their effect.

This also removes the "use Face Sets" option from the Mesh filter code,
as it was duplicated from the automasking code just to have that
funcitonality. This is now handled by the regular automasking system.

The "Use Face Sets" option is still available in the cloth filter as that
option limits the action of the forces, not the displacement.

After this, it is possible to initialize the automasking system
independently from the StrokeCache and Brush settings, so it can also be
added to more tools and features in the future.

Fixes T81619

Diff Detail

Repository
rB Blender
Branch
T81619 (branched from master)
Build Status
Buildable 10676
Build 10676: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 11 2020, 7:29 PM
Pablo Dobarro (pablodp606) created this revision.
Pablo Dobarro (pablodp606) retitled this revision from Fix T81619: Make Filters use the Sculpt Automasking settings to Sculpt: Add global automasking settings support in filters.
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)

Seems fine.
Suggestion is to unify automask vs. automasking in variable naming. For the rest seems rather straightforward change. Testing I'll leave up to you :)

This revision is now accepted and ready to land.Oct 15 2020, 4:49 PM