Fix T81656: Crash relocating a linked library into the current .blend
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 13 2020, 11:44 AM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T81656: Crash when trying to make the actual .blend file a relocated linked library into itself

Commits

rB16289274ed6f: Fix T81656: Crash relocating a linked library into the current .blend

Summary

A .blend file cannot use itself as a library.
This is prevented when linking manually, but was still possible when
relocating, which is now prevented.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 13 2020, 11:44 AM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) added a project: Pipeline, Assets & I/O.Oct 13 2020, 11:44 AM

Harbormaster completed remote builds in B10701: Diff 29879.Oct 13 2020, 11:45 AM

Besides note below, LGTM

source/blender/windowmanager/intern/wm_files_link.c
1060	Please use API `BKE_main_blendfile_path`

This revision is now accepted and ready to land.Oct 13 2020, 1:53 PM

Closed by commit rB16289274ed6f: Fix T81656: Crash relocating a linked library into the current .blend (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 13 2020, 2:44 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB16289274ed6f: Fix T81656: Crash relocating a linked library into the current .blend.

Lucas Schlindwein (Xlindvain) awarded a token.Oct 13 2020, 3:21 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

windowmanager/

intern/

wm_files_link.c

9 lines

Diff 29887

View Options

source/blender/windowmanager/intern/wm_files_link.c

Fix T81656: Crash relocating a linked library into the current .blendClosedPublicActions