Differential D9197

Fix T81594: Unable to reassign effect inputs
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 13 2020, 5:29 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T81594: Unable to reassign input for effect strips in the Sequencer

Commits

rB2c14a950a718: Fix T81594: Unable to reassign effect inputs

Summary

This was caused by canceling operator if strip has more than 0 inputs.
Logic should be reversed - cancel only if strip has 0 inputs.

BKE_sequencer_render_loop_check() arguments had to be sanitized because
seq_effect_find_selected() can set seq1,2,3 to NULL

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Oct 13 2020, 5:29 PM

Harbormaster completed remote builds in B10711: Diff 29898.Oct 13 2020, 5:29 PM

Richard Antalik (ISS) requested review of this revision.Oct 13 2020, 5:29 PM

Sergey Sharybin (sergey) accepted this revision.Oct 14 2020, 9:25 AM

This revision is now accepted and ready to land.Oct 14 2020, 9:25 AM

Closed by commit rB2c14a950a718: Fix T81594: Unable to reassign effect inputs (authored by Richard Antalik (ISS)). · Explain WhyOct 17 2020, 7:03 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB2c14a950a718: Fix T81594: Unable to reassign effect inputs.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_sequencer/

sequencer_edit.c

2 lines

sequencer/

intern/

sequencer.c

4 lines

Diff 30038

View Options

source/blender/editors/space_sequencer/sequencer_edit.c