Cleanup GPU: get rid of some extremely legacy draw code.
ClosedPublic
Actions

Authored by Antonis Ryakiotakis (psy-fi) on Nov 28 2014, 1:16 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Jason Wilkins (jwilkins)
Sergey Sharybin (sergey)

Commits

rBS2b7e1c6011d5: Cleanup GPU: get rid of some extremely legacy draw code.
rB2b7e1c6011d5: Cleanup GPU: get rid of some extremely legacy draw code.

Summary

Basically this commit gets rid of most of the derived mesh immediate mode
drawing (cases such as subsurf excluded). Even when VBO is turned off
in user preferences, we still use vertex arrays, which are very similar to
VBOs but memory is client side. Vertex arrays are OpenGL 1.1 so compatibility
is not an issue here.

Diff Detail

Repository: rB Blender
Branch: gpu_cleanup

Event Timeline

Antonis Ryakiotakis (psy-fi) updated this revision to Diff 2945.Nov 28 2014, 1:16 PM

Antonis Ryakiotakis (psy-fi) retitled this revision from to Cleanup GPU: get rid of some extremely legacy draw code..

Antonis Ryakiotakis (psy-fi) added reviewers: Campbell Barton (campbellbarton), Sergey Sharybin (sergey), Jason Wilkins (jwilkins).

Antonis Ryakiotakis (psy-fi) updated this object.

only minor points which infact relate to old code too.
LGTM

source/blender/blenkernel/intern/cdderivedmesh.c
401	can be a bool too, noticed this could be changed elsewhere too.
515	again, this is used elsewhere, but not fond of term `actualFace`... whats it even mean?

This revision is now accepted and ready to land.Nov 28 2014, 2:05 PM

This reminds me about possibly renaming "draw normal" to something else like "draw default" since that always tripped me up, but I'm not even sure if that is relavent after this patch.

Other than that this looks pretty straightforward.

Alrighty, commiting! Thanks for the review!

Closed by commit rB2b7e1c6011d5: Cleanup GPU: get rid of some extremely legacy draw code. (authored by Antonis Ryakiotakis (psy-fi)). · Explain WhyNov 28 2014, 3:45 PM

This revision was automatically updated to reflect the committed changes.