Sculpt: Smooth deform type for Boundary Brush
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 14 2020, 1:46 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB2b2f3da721bf: Sculpt: Smooth deform type for Boundary Brush

Summary

This adds a smooth deformation type to the boundary brush, which smooths
the boundary and has a regular falloff towards the inside of the mesh.
For smoothing, only vertices parallel to the boundary are taken into
account, creating this effect.

Diff Detail

Repository

rB Blender

Branch

sculpt-boundary-smooth (branched from master)

Build Status

Buildable 10716
Build 10716: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 14 2020, 1:46 AM

Harbormaster completed remote builds in B10716: Diff 29915.Oct 14 2020, 1:46 AM

Pablo Dobarro (pablodp606) requested review of this revision.Oct 14 2020, 1:46 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 14 2020, 1:47 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Fran Marz (franMarz) awarded a token.Oct 14 2020, 10:23 AM

Sergey Sharybin (sergey) requested changes to this revision.Oct 14 2020, 10:44 AM

Sergey Sharybin (sergey) added inline comments.

source/blender/editors/sculpt_paint/sculpt_boundary.c
877	`pass` becomes `area`? `symm` -> `symmetry`.
878	Think this can be `const`.
891	Use early `continue`.
896	`average` and `accumulator` are kind of mutually exclusive. You accumulate neighbour coordinates, and then average them. Variable names should represent what the value is inside. Even `coord_accum` is the better choice here.
924–926	Tag vertices for update even if they are not modified? Seems weird.