Avoid Assert in BKE_mesh_calc_loop_tangent_ex
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 14 2020, 4:17 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Maniphest Tasks

T81398: Blender 2.90.1 crashes on switching to viewport rendered view

Commits

rBe1cd6fae3425: Avoid Assert in BKE_mesh_calc_loop_tangent_ex

Summary

Code could call CustomData_get_layer_index_n with a negative index (if
no active and/or render UV layers are found). This would assert since
rBe86785c51445.

Diff Detail

Repository

rB Blender

Branch

CustomData_get_layer_index_n__assert (branched from master)

Build Status

Buildable 10727
Build 10727: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 14 2020, 4:17 PM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) added a project: Modeling.Oct 14 2020, 4:18 PM

Harbormaster completed remote builds in B10727: Diff 29936.Oct 14 2020, 4:19 PM

Bastien Montagne (mont29) accepted this revision.Oct 14 2020, 4:39 PM

This revision is now accepted and ready to land.Oct 14 2020, 4:39 PM

Philipp Oeser (lichtwerk) added a task: T81398: Blender 2.90.1 crashes on switching to viewport rendered view .Oct 18 2020, 10:48 AM

Closed by commit rBe1cd6fae3425: Avoid Assert in BKE_mesh_calc_loop_tangent_ex (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 18 2020, 10:58 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBe1cd6fae3425: Avoid Assert in BKE_mesh_calc_loop_tangent_ex.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

mesh_tangent.c

8 lines

Diff 29936

View Options

source/blender/blenkernel/intern/mesh_tangent.c

Avoid Assert in BKE_mesh_calc_loop_tangent_exClosedPublicActions