Page MenuHome

Fix T68343: Rendered video plays at 600fps
ClosedPublic

Authored by Richard Antalik (ISS) on Oct 14 2020, 5:28 PM.

Details

Summary

Field time_base of video stream must be set for some containers,
otherwise avformat_write_header() will set it to default values.
Rendered file in such case won't be played at desired frame rate.

See init_muxer() in mux.c in ffpmeg sources.


So compiler bug was false flag. Done some digging and I found core of the issue, though some details are not crystal clear like why AVI does this and why MPEG not, but seems that fix is working well.

Diff Detail

Repository
rB Blender
Branch
T68343 (branched from master)
Build Status
Buildable 10729
Build 10729: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 14 2020, 5:28 PM
Richard Antalik (ISS) created this revision.
Richard Antalik (ISS) edited the summary of this revision. (Show Details)Oct 14 2020, 5:32 PM

Seems reasonable. FFmpeg source was always source of truth for such things anyway.

Please export few different videos with different built-in presets, just to be sure. If that passes, go ahead and commit.

This revision is now accepted and ready to land.Oct 14 2020, 6:30 PM
This revision was automatically updated to reflect the committed changes.