Paths

Table of Contentst

Differential D9221

Fix T81580: No doversion for Emission Strength
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Oct 15 2020, 3:17 PM.

Tags

Subscribers

Sybren A. Stüvel (sybren)

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T81580: Keyframed Principled Shader "Alpha" Values in older files get mapped to "Emission Strength" in 2.91

Commits

rBc866075dfbd9: Fix T81580: No doversion for Emission Strength

Summary

The new parameter made so that previously keyed Alpha values were lost
and instead the new "Emission Strength" was keyed.

Issue introduced with the original commit of Emission Strength: rBb248ec97769f

Note: Files created since the issue (September 17) that keyframed the Emission Strength will have to fix their files manually.

Diff Detail

Repository

Branch

fix-T81850-doversion-emission-strength (branched from master)

Build Status

Buildable 10746
Build 10746: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) created this revision.Oct 15 2020, 3:17 PM

Harbormaster completed remote builds in B10737: Diff 29959.Oct 15 2020, 3:17 PM

Dalai Felinto (dfelinto) requested review of this revision.Oct 15 2020, 3:17 PM

Dalai Felinto (dfelinto) planned changes to this revision.Oct 15 2020, 3:22 PM

From review: use API

Note: will update the patch description now.

Harbormaster completed remote builds in B10741: Diff 29966.Oct 15 2020, 6:22 PM

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Oct 15 2020, 6:23 PM

Update comments of new function

Harbormaster completed remote builds in B10742: Diff 29967.Oct 15 2020, 6:25 PM

Dalai Felinto (dfelinto) added a task: T81580: Keyframed Principled Shader "Alpha" Values in older files get mapped to "Emission Strength" in 2.91.Oct 15 2020, 6:27 PM

I should add that I tested with keyframe and drivers, not with NLA (not sure how to test with NLA). My test file:

emission-strength-doversion.blend166 KBDownload

Dalai Felinto (dfelinto) added a project: Animation & Rigging.Oct 15 2020, 6:31 PM

Sybren A. Stüvel (sybren) requested changes to this revision.Oct 15 2020, 6:31 PM

Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).

Sybren A. Stüvel (sybren) added inline comments.

source/blender/blenkernel/BKE_animsys.h
155	End in period.
source/blender/blenkernel/intern/anim_data.c
1428–1430	These can be `const`
source/blender/blenloader/intern/versioning_290.c
254–255	Why are 18 and 19 the values to use?

This revision now requires changes to proceed.Oct 15 2020, 6:31 PM

From review: comments and cleanup

Harbormaster completed remote builds in B10743: Diff 29969.Oct 15 2020, 6:38 PM

Final pass based on feedback (comment clarification)

Harbormaster completed remote builds in B10744: Diff 29970.Oct 15 2020, 6:42 PM

Update: play safe and move all the channels past 18 one up

Harbormaster completed remote builds in B10745: Diff 29982.Oct 15 2020, 7:51 PM

Reverting the for loop

Harbormaster completed remote builds in B10746: Diff 29983.Oct 15 2020, 7:54 PM

Update: play safe and move all the channels past 18 one up

Bringing this back again based on review on blender.chat

Harbormaster completed remote builds in B10747: Diff 29985.Oct 15 2020, 7:56 PM

Sybren A. Stüvel (sybren) accepted this revision.Oct 15 2020, 7:57 PM

This revision is now accepted and ready to land.Oct 15 2020, 7:57 PM

Closed by commit rBc866075dfbd9: Fix T81580: No doversion for Emission Strength (authored by Dalai Felinto (dfelinto)). · Explain WhyOct 15 2020, 8:16 PM

This revision was automatically updated to reflect the committed changes.

Dalai Felinto (dfelinto) added a commit: rBc866075dfbd9: Fix T81580: No doversion for Emission Strength.

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Oct 15 2020, 8:34 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

10 lines

BKE_blender_version.h

2 lines

intern/

36 lines

blenloader/

intern/

versioning_290.c

59 lines

Diff 29983

source/blender/blenkernel/BKE_animsys.h

Loading...

source/blender/blenkernel/BKE_blender_version.h

Loading...

source/blender/blenkernel/intern/anim_data.c

Loading...

source/blender/blenloader/intern/versioning_290.c

Loading...