Fix T81729: Cycles object color not updating for instancers
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 15 2020, 3:19 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T81729: Object Color change doesn't update the rendering in 2.90+ for instanced collections (both linked and local)

Commits

rCdc85ccce4db1: Fix T81729: Cycles object color not updating for instancers
rB9c7fda6de3e8: Fix T81729: Cycles object color not updating for instancers

Summary

Caused by rBe65c78cd43aa.

Since above commit, only geometry and lights received the update,
previous to this check an instancer would receive that is well (in case
of 'is_updated_shading').

Now check for an instancer (checking OB_DUPLI via ob.is_instancer --
more finegrained checks could be made here) and do an update then as well
(in case of 'is_updated_shading' of course)

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 15 2020, 3:19 PM

Harbormaster completed remote builds in B10738: Diff 29960.Oct 15 2020, 3:19 PM

Philipp Oeser (lichtwerk) requested review of this revision.Oct 15 2020, 3:19 PM

Thanks.

intern/cycles/blender/blender_object.cpp
62–70 ↗	(On Diff #29960)	No need to have this as its own function or do more detailed checks. It's better to tag too much than to make this code more expensive. Just use `b_ob.is_instancer()` in `blender_sync.cpp`.