Page MenuHome
Differential D9223

Cleanup: Simplify check and reset of ID->recalc flags
Needs ReviewPublic
Actions

Authored by Sergey Sharybin (sergey) on Oct 15 2020, 3:34 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Summary

Compare to 0 when it is needed to know whether there are any
recalc bits set. Set to 0 when the ID is fully updated.

The ID_RECALC_ALL was used for such checks due to legacy reasons,
where particle system recalc flags were encoded into same field
in DNA but used different set of bits. Now all recalc bits have
common nature, no need to separate them.

Since the ID_RECALC_ALL is assigned to all ones in binary there
expected to be no changes in behavior.

Diff Detail

Repository
rB Blender
Branch
cleanup_remove_recalc_all (branched from master)
Build Status
Buildable 10739
Build 10739: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Oct 15 2020, 3:34 PM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B10739: Diff 29962.Oct 15 2020, 3:34 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
5 lines
3 lines
depsgraph/
intern/
4 lines
4 lines
draw/
engines/
workbench/
2 lines
makesrna/
intern/
2 lines
modifiers/
intern/
3 lines

Diff 29962

View Options

source/blender/blenkernel/intern/object.c

Loading...
View Options

source/blender/blenkernel/intern/scene.c

Loading...
View Options

source/blender/depsgraph/intern/depsgraph_query_iter.cc

Loading...
View Options

source/blender/depsgraph/intern/depsgraph_tag.cc

Loading...
View Options

source/blender/draw/engines/workbench/workbench_engine.c

Loading...
View Options

source/blender/makesrna/intern/rna_depsgraph.c

Loading...
View Options

source/blender/modifiers/intern/MOD_correctivesmooth.c

Loading...