Page MenuHome

Fix T81027: Multires objects in sculpt mode can't be linked via collections.
ClosedPublic

Authored by Bastien Montagne (mont29) on Oct 16 2020, 11:40 AM.

Details

Summary

Just clear all non-object mode flags from linked objects at read time.

Diff Detail

Repository
rB Blender
Branch
T81027 (branched from master)
Build Status
Buildable 10753
Build 10753: arc lint + arc unit

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Oct 16 2020, 11:41 AM

@Brecht Van Lommel (brecht) would not expect this change to cause any issue, but am wondering why we were only selectively clearing some edit flags for linked objects here, so would not mind a second pair of eyes to be sure am not missing something?

Makes sense, but the logic here seems more complicated than it needs to be.

if(ob->id.tag & (LIB_TAG_EXTERN | LIB_TAG_INDIRECT))) {
    ob->mode &= ~OB_MODE_ALL_MODE_DATA;
}
else if(is_undo) {
    ob->mode &= ~(OB_MODE_EDIT | OB_MODE_PARTICLE_EDIT);
}

These are really two distinct cases, no need to mix them together.

This revision is now accepted and ready to land.Oct 16 2020, 1:06 PM

Thanks, was thinking about splitting this indeed.