Differential D9252

Fix T81806: Error getting Cycles GPU devices if device_type is set to NONE
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 18 2020, 1:08 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T81806: Error getting Cycles GPU devices if device_type is set to NONE

Summary

Caused by rB1001adb50019.

Cycles cannot get number of gpu devices for type "None", return 0 in
that case.
(Havent tracked down exactly why rB1001adb50019 exposes this, but seems
safe to assume that we should return 0 if getting here in any case.)

Diff Detail

Repository

rB Blender

Branch

T81806 (branched from master)

Build Status

Buildable 10781
Build 10781: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 18 2020, 1:08 PM

Harbormaster completed remote builds in B10781: Diff 30067.Oct 18 2020, 1:08 PM

Philipp Oeser (lichtwerk) requested review of this revision.Oct 18 2020, 1:08 PM

Philipp Oeser (lichtwerk) added projects: User Interface, Render & Cycles.Oct 18 2020, 1:09 PM

Thanks for checking on this.

It was a regression in rB4bea4702d5d5: PyAPI: throw exception when cycles is given an invalid device name. Committed an alternate fix for this: rB4d9f357bf6b5: Fix T81806: Cycles error when GPU device_type is NONE

Campbell Barton (campbellbarton) abandoned this revision.Oct 19 2020, 3:11 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

blender/

addon/

properties.py

3 lines

Diff 30067

View Options

intern/cycles/blender/addon/properties.py

Fix T81806: Error getting Cycles GPU devices if device_type is set to NONEAbandonedPublicActions