The operator now uses ED_transform_snap_object_context_create_view3d
Details
Details
- Reviewers
Campbell Barton (campbellbarton) - Maniphest Tasks
- T81079: "Switch Object" ignores view-visibility settings
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T81079 (branched from master)
- Build Status
Buildable 10829 Build 10829: arc lint + arc unit
Event Timeline
Comment Actions
While this is OK, I'm not sure why this is used instead of Base *base = ED_view3d_give_base_under_cursor(C, event->mval); as is used for dropping materials onto objects - for example.
This has the advantage that it works for non-geometry objects (armatures for e.g.)
Comment Actions
@Campbell Barton (campbellbarton) Because it needs the surface location to update the view orbiting point as you change between different objects.
Comment Actions
Why not use ED_view3d_autodist_simple & ED_view3d_depth_unproject for this?
Then this can support non geometry objects (armatures for eg)
Comment Actions
Committed with minor edits rB1ad100d5568c: Fix T81079: Switch object ignoring visibility settings.
- Only set average_stroke_accum when last_mode is a paint mode.
- ED_view3d_autodist_simple may fail, don't set average_stroke_accum in that case.