Page MenuHome
Differential D9256

Fix T81076: Crash on switch object operator undo
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 18 2020, 7:18 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T81076: "Switch Object" fails to properly undo, crashes
Commits
rB14c089767110: Fix T81076: Crash on switch object operator undo
Summary

This fixes the crash and the assert, but undo is done in multiple steps

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 18 2020, 7:18 PM
Pablo Dobarro (pablodp606) created this revision.
Harbormaster completed remote builds in B10786: Diff 30077.Oct 18 2020, 7:18 PM
Pablo Dobarro (pablodp606) added a reviewer: Campbell Barton (campbellbarton).Oct 18 2020, 7:18 PM
Campbell Barton (campbellbarton) accepted this revision.Oct 19 2020, 2:45 PM

Requesting some minor changes, otherwise seems fine.

source/blender/editors/object/object_modes.c
480

Are you sure this is needed? use_undo=true in the command above.

487

This should be noted as FIXME, multiple undo operations per operator isn't what users would expect and should eventually be resolved (grouped in some way for e.g.).

519–520

Should note that undo pushes are handled by the operator.

This revision is now accepted and ready to land.Oct 19 2020, 2:45 PM
Closed by commit rB14c089767110: Fix T81076: Crash on switch object operator undo (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 20 2020, 1:23 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) marked 3 inline comments as done.
Pablo Dobarro (pablodp606) added a commit: rB14c089767110: Fix T81076: Crash on switch object operator undo.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
object/
17 lines

Diff 30166

View Options

source/blender/editors/object/object_modes.c

Loading...