Page MenuHome

Blender Game Engine: draws contact points as sphere + line indicating the surface normal.
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Dec 4 2014, 1:35 PM.

Diff Detail

Repository
rB Blender

Event Timeline

inactive account (sybrenstuvel) retitled this revision from to Blender Game Engine: draws contact points as sphere + line indicating the surface normal..

Hi Sybren,

I just checked the code and it works ok. The feature is useful to verify contacts points.

On the other hand, you shouldn't mix real implementation (in that case part inside of drawContactPoint function) with refactoring/cleaning the code.

Campbell, could you clarify if it is necessary to split the modification in 2 differential tasks due to the above exposed?

Apart from this, as refactor as implementation look good to me.

I agree; working on two split patches now.

Just the functionality in the patch. The clean-up of the code was submitted as separate patch (D954) and should be committed before this one.

This revision is now accepted and ready to land.Dec 25 2014, 11:19 PM
Campbell Barton (campbellbarton) edited edge metadata.

If the color change related? - if now would do 2x commits

It's kind of related. Previously the colour was irrelevant, as it wasn't used. Now it is, and having the same colour as other visualisations is distracting. Because of this I made it a single patch.

This revision was automatically updated to reflect the committed changes.

Committed in two parts, e5a852c3f38fc11f0cc2c8e5837a2fcd9721c9f8 (draw) and dd673337f1e07ea9c593b7182dbb28752da22a87 (change to yellow)