Differential D9263

Avoid massive console messages with custom nodes
ClosedPublic
Actions

Authored by Pedro A. (povmaniaco) on Oct 19 2020, 11:27 AM.

Tags

Subscribers

None

Tokens

"Love" token, awarded by gilberto_rodrigues.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rB93887d10961a: Fix: skip drawing input sockets that do not have a draw method

Summary

This patch avoid console messages with custom nodes when the addon that are create this nodes is disabled or not intalled.
In some cases, Blender can't manage this custom sockets and show this message:

Traceback (most recent call last):
  File "E:\apps\blender\2.90\scripts\startup\bl_ui\space_node.py", line 542, in draw
    socket.draw(
AttributeError: 'NodeSocket' object has no attribute 'draw'

location: <unknown location>:-1

location: <unknown location>:-1

Diff Detail

Event Timeline

Pedro A. (povmaniaco) requested review of this revision.Oct 19 2020, 11:27 AM

Pedro A. (povmaniaco) created this revision.

Jacques Lucke (JacquesLucke) accepted this revision.Oct 19 2020, 11:37 AM

This revision is now accepted and ready to land.Oct 19 2020, 11:37 AM

Pedro A. (povmaniaco) added a project: Nodes.Oct 19 2020, 11:39 AM

Do you have commit rights, or should I commit it?

In D9263#229004, @Jacques Lucke (JacquesLucke) wrote:

Do you have commit rights, or should I commit it?

Thanks for review @Jacques Lucke (JacquesLucke) ..you can commit, of course.

Closed by commit rB93887d10961a: Fix: skip drawing input sockets that do not have a draw method (authored by Jacques Lucke (JacquesLucke)). · Explain WhyOct 19 2020, 12:29 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB93887d10961a: Fix: skip drawing input sockets that do not have a draw method.

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Oct 22 2020, 11:10 PM

Revision Contents
Changeset List

Path

Size

		release/	scripts/	startup/	bl_ui/
	"a/	release/	scripts/	startup/	bl_ui/

	space_node.py
	space_node.py"

2 lines

Diff 30098

release/scripts/startup/bl_ui/space_node.py

Loading...