Page MenuHome

Fix T81484: Weight/Vertex paint with mirror and viewport clipping does not update stroke on initial side
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Oct 19 2020, 2:06 PM.

Details

Summary

Issue introduced in rB4f616c93f7cb.

Issue here is that the the StrokeCache mirror_symmetry_pass is still
in its previous state when entering
wpaint_do_symmetrical_brush_actions.
For the initial stroke this means that the (wrong) cache
mirror_symmetry_pass ends up in SculptBrushTest mirror_symmetry_pass
as well and thus the clipping test in sculpt_brush_test_clipping will
fail.
[ This one flips the coords to test against clipping according to (now
wrong) mirror_symmetry_pass ]

Solution seems simple: just ensure we start of with a
mirror_symmetry_pass of zero in wpaint_do_symmetrical_brush_actions
for the initial stroke.
Same thing is done for vertex paint as well.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 19 2020, 2:06 PM
Philipp Oeser (lichtwerk) created this revision.

While this seems fine, longer term it could be good to see if we can keep this in sync with sculpt mode's do_symmetrical_brush_actions, since the code is already sharing quite a bit of functionality.

This revision is now accepted and ready to land.Oct 19 2020, 2:29 PM