Paths

Table of Contentst

UI: Playback Synchronization menu improvement
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Oct 19 2020, 3:09 PM.

Details

Reviewers

Luciano Muñoz Sessarego (looch)
Julian Eisel (Severin)
Pablo Vazquez (pablovazquez)
Hans Goudey (HooglyBoogly)
Campbell Barton (campbellbarton)

Group Reviewers

Animation & Rigging
User Interface

Commits

rBf4e8c0c104f3: Anim UI: Playback Sync menu improvement

Summary

This is a followup of the improvements in D8434: UI: Changes to timeline playback popover.

The playback synchronization part of the menu was deemed a bit unclear; especially the "No Sync" option, as this describes what does not happen, rather than what does. Furthermore, the "Audio" label is misplaced, because this setting affects all of Blender's playback, and not just audio.

Change label from "Audio" to "Sync"
Change the labels of the sync enum:
- No Sync → Play Every Frame
- Frame Dropping stays the same
- AV-sync → Sync to Audio

The "Audio" label has moved one option down, as that option does relate to audio.

Diff Detail

Repository: rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Oct 19 2020, 3:09 PM

Sybren A. Stüvel (sybren) created this revision.

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Oct 19 2020, 3:10 PM

Sybren A. Stüvel (sybren) added reviewers: Animation & Rigging, User Interface.

Sybren A. Stüvel (sybren) added projects: BF Blender (2.91), Animation & Rigging, User Interface.

Harbormaster completed remote builds in B10804: Diff 30120.Oct 19 2020, 3:11 PM

Hans Goudey (HooglyBoogly) accepted this revision.Oct 19 2020, 4:25 PM

Hans Goudey (HooglyBoogly) added inline comments.

release/scripts/startup/bl_ui/space_time.py
243–244	This is a bit picky but this column is unnecessary now, this would be the same: `layout.prop(scene, "sync_mode", text="Synchronization")`

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Oct 19 2020, 4:30 PM

Aaron Carlisle (Blendify) added inline comments.

release/scripts/startup/bl_ui/space_time.py
244–245	Synchronization is a long word and can be hard to to read quickly. Sync might make more sense. Although it is an abbreviation it is a quit common short hand and still reads with the same meaning.

I do agree that "Synchronization" is a longer word, and that shortening it makes the popup a bit smaller & more balanced

But somehow I also feel that it's okay to use longer words? I mean, it's not like we're using Dutch with words like "desoxiribonucleinezuurreactievatkoelblokvastzethaakje".

Sybren A. Stüvel (sybren) marked an inline comment as done.Oct 20 2020, 10:20 AM

Remove unnecessary column

Harbormaster completed remote builds in B10817: Diff 30154.Oct 20 2020, 10:22 AM

Re: using "Sync" instead of "Synchronization", I think "Sync" is quite OK,
its good to avoid abbreviations when they're ambiguous, but I don't think that's an issue in this case.

If someone says "The audio is out of sync" it's quite clear what's meant.

This abbreviation is already used elsewhere too: Sync Markers, UV Sync Selection, Sync Outliner Selection. Sync Visible Range.

Agreed,

so it would be:

Sync:

"play every frame"
"frame dropping"
"to audio"

Luciano Muñoz Sessarego (looch) awarded a token.Oct 20 2020, 11:39 AM

Synchronization → Sync

Harbormaster completed remote builds in B10819: Diff 30158.Oct 20 2020, 11:55 AM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Oct 20 2020, 12:03 PM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)

It is better when the checkboxes in each group are aligned, (only checkboxes, but not the Sync menu and the next checkbox).

I also see text clipping at 2x/retina.

Also, it's hard to to read quickly:
"Set Start Frame" / "Set End Frame"

This is much easier:
Set Frame: "Start" / "End"

Sybren A. Stüvel (sybren) marked an inline comment as done.Oct 20 2020, 2:19 PM

Campbell Barton (campbellbarton) accepted this revision as: Campbell Barton (campbellbarton).Oct 28 2020, 11:47 AM

Seems good
@Yevgeny Makarov (jenkm)'s points are fair but not strictly related to this patch. Do you want to create a patch for this @Yevgeny Makarov (jenkm)?