Page MenuHome
Differential D9272

Cleanup: Simplify outliner mode column drawing function
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Oct 19 2020, 9:14 PM.

Details

Reviewers
Nathan Craddock (natecraddock)
Commits
rB3d916c0a966c: Cleanup: Simplify outliner mode column drawing function
Summary

This patch simplifies the mode column button function.

The main change is moving the checks for whether to draw the button to the
beginning of the function, and centralizing them a bit. This also uses a
shorthand variable for ob_active. Hopefully this makes the function a bit
more readable, it also makes additional code for an upcoming bug fix
less messy.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Oct 19 2020, 9:14 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B10809: Diff 30135.Oct 19 2020, 9:14 PM
Hans Goudey (HooglyBoogly) added a child revision: D9273: Fix T81818: Outliner mode column does not consider shared object data.Oct 19 2020, 9:24 PM
Hans Goudey (HooglyBoogly) added a project: User Interface.Oct 19 2020, 9:26 PM
Nathan Craddock (natecraddock) accepted this revision.Oct 20 2020, 6:20 AM

Looks much cleaner! I didn't notice any difference in behavior after this change.

source/blender/editors/space_outliner/outliner_draw.c
1957–1960

Perhaps add the missing . I forgot if that's okay to include with this cleanup

This revision is now accepted and ready to land.Oct 20 2020, 6:20 AM
Hans Goudey (HooglyBoogly) marked an inline comment as done.Oct 22 2020, 10:46 PM
Closed by commit rB3d916c0a966c: Cleanup: Simplify outliner mode column drawing function (authored by Hans Goudey (HooglyBoogly)). · Explain WhyOct 22 2020, 10:50 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB3d916c0a966c: Cleanup: Simplify outliner mode column drawing function.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_outliner/
103 lines

Diff 30281

View Options

source/blender/editors/space_outliner/outliner_draw.c

Loading...