Fix T81818: Outliner mode column does not consider shared object data
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Oct 19 2020, 9:24 PM.

Details

Reviewers

Nathan Craddock (natecraddock)
Julian Eisel (Severin)

Maniphest Tasks

T81818: Crash using outliner editmode shortcuts for objects with linked data

Commits

rB8e060b44da04: Fix T81818: Outliner mode column crashes with shared object data

Summary

For objects with shared data, it makes sense to show the mode icon for every
object sharing the same data if one of them is in edit mode.

This also disables the "extend" functionality in this case, because
being in edit mode for multiple objects with the same data isn't supported.

It might be nice to distinguish the "shared data edit modes" from the regular
buttons a bit, but we don't have great icons for that.

Depends on D9272

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Oct 19 2020, 9:24 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B10810: Diff 30137.Oct 19 2020, 9:25 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Oct 19 2020, 9:26 PM

Hans Goudey (HooglyBoogly) added projects: User Interface, BF Blender (2.91).

Hans Goudey (HooglyBoogly) added a task: T81818: Crash using outliner editmode shortcuts for objects with linked data.

Small requests.

source/blender/editors/space_outliner/outliner_draw.c
1938	There should be some kind of sanity check here, before just assuming this is an object.
1984	Would prefer not using bitwise operations for something that doesn't represent a bitfield.

This revision now requires changes to proceed.Oct 20 2020, 3:38 PM

I don't see any other code issues, and it works well.

Hans Goudey (HooglyBoogly) marked 2 inline comments as done.Oct 22 2020, 11:08 PM

Don't use bitwise operand on bool
Add assert to check if item type is object

Harbormaster completed remote builds in B10875: Diff 30282.Oct 22 2020, 11:08 PM

Julian Eisel (Severin) accepted this revision.Oct 22 2020, 11:10 PM

This revision is now accepted and ready to land.Oct 22 2020, 11:10 PM

Closed by commit rB8e060b44da04: Fix T81818: Outliner mode column crashes with shared object data (authored by Hans Goudey (HooglyBoogly)). · Explain WhyOct 23 2020, 1:13 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB8e060b44da04: Fix T81818: Outliner mode column crashes with shared object data.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_outliner/

outliner_draw.c

14 lines

Diff 30287

View Options

source/blender/editors/space_outliner/outliner_draw.c

Fix T81818: Outliner mode column does not consider shared object dataClosedPublicActions