Page MenuHome

Fix T81794: ColorRampElement step regression
ClosedPublic

Authored by Richard Antalik (ISS) on Oct 20 2020, 7:01 AM.

Details

Summary

Bisecting this issue showed rBe6f0b60c2e9111af1878d31dcc295c59ed1bea77 as commit that broke behavior, but I noticed that it has been broken once more earlier.
This was reliably working up to 2.90.

I am not sure if other properties were affected in the same way as this one and I am not sure if this fix is the correct solution.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 20 2020, 7:01 AM

I'm not against this change but it seems like a regression in the UI code that should be fixed on that level too. I didn't investigate it yet though.

I realized that the cause is actually pretty stupid: There was a hardcoded setting of a1 for this specific button, which used to be the variable to store the step size of number buttons until rBe6f0b60c2e91. Removed that now rBe29206f86a5f.

So this patch is the correct way of fixing the bug.

This revision is now accepted and ready to land.Nov 3 2020, 10:39 PM

I forgot to consult this after your first comment. I thought this was the case though. Thanks for checking.

This revision was automatically updated to reflect the committed changes.