Differential D9281

Clang-tidy: disable new warnings
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Oct 20 2020, 2:07 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBee90effd3a3e: Clang-tidy: disable new warnings.

Summary

Until it is decided whether to work on, or ignore these
warning, disable them.

Diff Detail

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Oct 20 2020, 2:07 PM

Ankit Meel (ankitm) created this revision.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Ankit Meel (ankitm) added a task: T78535: Code quality day: Clang-Tidy.

comma

There are more.
Found so far:

bugprone-exception-escape,
-readability-named-parameter,

new ones

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Oct 20 2020, 9:47 PM

Ankit Meel (ankitm) removed a task: T78535: Code quality day: Clang-Tidy.

Ankit Meel (ankitm) retitled this revision from Clang-tidy: disable readability-function-cognitive-complexity to Clang-tidy: disable new warnings .

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Ankit Meel (ankitm) added a reviewer: Sergey Sharybin (sergey).Oct 20 2020, 9:50 PM

I think those warnings are nice to be officially enabled one day, so please add them to the list in T78535.

@Sybren A. Stüvel (sybren), is there a way in YAML to mix comment and a string? To make it clear that some group of warnings is disabled permanently and another one is disabled temporarily?

This revision is now accepted and ready to land.Oct 21 2020, 9:14 AM

Closed by commit rBee90effd3a3e: Clang-tidy: disable new warnings. (authored by Ankit Meel (ankitm)). · Explain WhyOct 21 2020, 9:29 AM

This revision was automatically updated to reflect the committed changes.

Ankit Meel (ankitm) added a commit: rBee90effd3a3e: Clang-tidy: disable new warnings..

Revision Contents
Changeset List

Path

Size

.clang-tidy

7 lines

Diff 30197

View Options

Clang-tidy: disable new warnings ClosedPublicActions