Paths

Table of Contentst

Differential D9287

Fix Symmetry options in weight paint UI
ClosedPublic
Actions

Authored by Demeter Dzadik (Mets) on Oct 20 2020, 5:28 PM.

Details

Reviewers

Pablo Dobarro (pablodp606)

Commits

rBe9d21136ce22: UI: Fix Symmetry options in weight paint panels

Summary

This patch removes one and moves one checkbox in the Weight Paint Options panel in the sidebar.

The now redundant "X" checkbox is removed since it's also present in the Symmetry panel above.
The Topology Mirror is moved into the Symmetry panel also.

This was needed because bpy.types.Mesh.use_x_mirror has recently been turned into a different functionality, and its old functionality now lives under bpy.types.Mesh.use_mirror_vertex_group_x. This is a good change, but something went wrong in the UI:

Diff Detail

Event Timeline

an oopsie

Was this also the thing in T81745: Assign Automatic Weights fails with Mirror Modifier + Vertex Groups X Symmetry on?

reg. Topology Mirror: there have been reports about this once in a while (I, too, find this beast hard to grasp, but apparently this works once in a while), there is this one open T81698: Topology Mirror usage

As far as I know, the X mirror means replicating the stroke using the YZ plane, Topology mirror means copying the resulting stroke to the vertex group named with an R instead of a L in weight paint and calculating the same transform using the mesh topology instead of the YZ plane in edit mode. That was working at some point, but if it does no longer works, it is probably a bug.

This revision is now accepted and ready to land.Oct 20 2020, 5:47 PM

Demeter Dzadik (Mets) mentioned this in T81745: Assign Automatic Weights fails with Mirror Modifier + Vertex Groups X Symmetry on.Oct 20 2020, 6:23 PM

In D9287#229751, @Pablo Dobarro (pablodp606) wrote:

As far as I know, the X mirror means replicating the stroke using the YZ plane, Topology mirror means copying the resulting stroke to the vertex group named with an R instead of a L in weight paint and calculating the same transform using the mesh topology instead of the YZ plane in edit mode. That was working at some point, but if it does no longer works, it is probably a bug.

In the days of old, "X-Mirror" was the option responsible for vertex group name based mirroring. That was always a confusing name though. This is now "Vertex Groups X Symmetry" which is verbose but for good reason. Topology Mirror as far as I know doesn't have to do with vertex groups, but I have never used it so it is a mystery to me.

In D9287#229743, @Philipp Oeser (lichtwerk) wrote:

Was this also the thing in T81745: Assign Automatic Weights fails with Mirror Modifier + Vertex Groups X Symmetry on?

Yes, I updated that report now to clean up some of my own confusion in it.

I don't have commit rights for master(I think) so if this can go in someone please arc land this for me :D

It's a lot easier to jump in and commit something like this if there is already a proper commit message, which should use this style guide, https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

It also shouldn't contain things like "I noticed today while weight painting" etc, just the changes, their reasoning and anything else important.

I edited it so it's a bit more to the point! I hope that works.

Closed by commit rBe9d21136ce22: UI: Fix Symmetry options in weight paint panels (authored by Hans Goudey (HooglyBoogly)). · Explain WhyOct 26 2020, 5:16 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBe9d21136ce22: UI: Fix Symmetry options in weight paint panels.

I had to add mesh = context.object.data to get it to work, and I also committed a follow-up using property split here.

In the process of amending your original commit the authorship got changed, I'm really sorry about that. I just made a similar mistake recently.. now I have learned the lesson twice I guess. I just need to check before pushing next time...

Hans Goudey (HooglyBoogly) mentioned this in rBe9d21136ce22: UI: Fix Symmetry options in weight paint panels.Oct 26 2020, 5:30 AM

haha well if I mess up a 5 line patch I deserve it! No worries :'D

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_view3d_toolbar.py

11 lines

Diff 30184

View Options

release/scripts/startup/bl_ui/space_view3d_toolbar.py

Fix Symmetry options in weight paint UIClosedPublicActions