Differential D9290
Remove duplicate of map_mode Authored by Ivan Perevala (ivpe) on Oct 20 2020, 11:15 PM. Tags Subscribers None
Details Remove duplicate of map_mode It was the only places where tex_paint_map_mode exist.
Diff Detail
Event TimelineComment Actions Add-ons are located in a different git repository. These changes needs to be send in a separate patch.
Comment Actions @Jeroen Bakker (jbakker) Is it correct not to remove this enum from RNA, but to correct the relationships in the python modules? At the moment map_mode is also used in places where tex_paint_map_mode should be Comment Actions I expect to that the prop_map_mode_items is moved outside the function and add a similar function like this. static const EnumPropertyItem *rna_BrushTextureSlot_map_mode_itemf(bContext *C,
PointerRNA *UNUSED(ptr),
PropertyRNA *UNUSED(prop),
bool *r_free)
{
const bool in_sculpt_mode = ... /* to be completed */
int totitem = 0;
EnumPropertyItem *result = NULL;
for (int i = 0; rna_brush_texture_slot_map_mode_items[i].identifier != NULL; i++) {
const EnumPropertyItem *item = &rna_brush_texture_slot_map_mode_items[i];
if (item->value != MTEX_MAP_MODE_AREA || in_sculpt_mode) {
RNA_enum_item_add(&result, &totitem, item);
}
}
RNA_enum_item_end(&result, &totitem);
*r_free = true;
return result;
}With an itemf function it is possible to set the possible enum values based on the context that the user is working on. Here for example when the user is in sculpt mode all values are displayed, but when in texture mode the area isn't. This function should be linked to the map_mode rna property with RNA_def_property_enum_funcs.
Comment Actions Committed rBeebe27431286: RNA: remove duplicate of Brush.tex_paint_map_mode with minor change (support NULL context, no need for allocation). Also updated the one add-on that used this. | ||||||||||||||||||||||||||||