camera.html and Brown-Conrady lens distortion model
ClosedPublic
Actions

Authored by Vlad Kuzmin (Ssh4) on Oct 21 2020, 2:22 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Aaron Carlisle (Blendify)

Commits

rBM7285: Brown-Conrady lens distortion model

Summary

Added information about new Brown-Conrady lens distortion. With more deeper explanation about used coefficients and some image samples of lens distortions.

Example of Radial distortion (K coefficients)

Example of Tangential distortion (P coefficients)

Diff Detail

Event Timeline

Vlad Kuzmin (Ssh4) requested review of this revision.Oct 21 2020, 2:22 PM

Vlad Kuzmin (Ssh4) created this revision.

Sergey Sharybin (sergey) added a reviewer: Aaron Carlisle (Blendify).Oct 21 2020, 2:26 PM

Vlad Kuzmin (Ssh4) edited the summary of this revision. (Show Details)Oct 21 2020, 2:33 PM

Sergey Sharybin (sergey) added inline comments.Oct 21 2020, 2:50 PM

manual/movie_clip/tracking/clip/properties/track/camera.rst
68	I am not sure what `-K and +K` is. Dis you mean `-K1 and +K2`? But then for barel distortion it is -K1 and -K2, and unstortion is +k2 and +K2.
78	Typo? `Tangential distortion -P1 and -P2 (+P1 and +P2 for undistortion)`

Ivan Perevala (ivpe) awarded a token.Oct 21 2020, 4:54 PM

Ivan Perevala (ivpe) rescinded a token.

Ivan Perevala (ivpe) awarded a token.

Aaron Carlisle (Blendify) added inline comments.Oct 21 2020, 5:27 PM

manual/movie_clip/tracking/clip/properties/track/camera.rst
39	Should be "Uses" not "Use" same with the other definitions
46	"Brown-Conrady is one of most"...
57	Use title case here "Radial Distortion Coefficients (K1-K4)" same with the other definition
75–78	Indent this figure block so the image is part of the definition. Same with the other figure.

Fixed some typo, formatting and coefficients explanation.

Vlad Kuzmin (Ssh4) marked 3 inline comments as done.Oct 22 2020, 12:11 PM

Vlad Kuzmin (Ssh4) added inline comments.

manual/movie_clip/tracking/clip/properties/track/camera.rst
75–78	Can you please check if i fixed this?

Vlad Kuzmin (Ssh4) marked 3 inline comments as done.Oct 23 2020, 6:38 AM

Vlad Kuzmin (Ssh4) added inline comments.

manual/movie_clip/tracking/clip/properties/track/camera.rst
75–78	This block is not related to Coefficients. But i can't put in under the Optical Center because it more like small advice after user read about distortion coefficients. Because changes in Optical Center also affect how distortion coefficients are working.