Page MenuHome
Differential D9298

Update "Dynamic Brush Menus" addon
ClosedPublic
Actions

Authored by Ivan Perevala (ivpe) on Oct 21 2020, 4:26 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Ryan Inch (Imaginer)
Summary

Updating "Dynamic Brush Menus" addon, relative to D9290

Diff Detail

Event Timeline

Ivan Perevala (ivpe) requested review of this revision.Oct 21 2020, 4:26 PM
Ivan Perevala (ivpe) created this revision.
Harbormaster completed remote builds in B10852: Diff 30227.Oct 21 2020, 4:26 PM
Ivan Perevala (ivpe) retitled this revision from Update texture_menu.py to Update space_view3d_brush_menus/texture_menu.py.Oct 21 2020, 4:29 PM
Ivan Perevala (ivpe) edited the summary of this revision. (Show Details)
Ivan Perevala (ivpe) added a reviewer: Jeroen Bakker (jbakker).
Ivan Perevala (ivpe) added a project: Add-ons (BF-Blender).
Ivan Perevala (ivpe) added a parent revision: D9290: Remove duplicate of map_mode.
Ivan Perevala (ivpe) retitled this revision from Update space_view3d_brush_menus/texture_menu.py to Update "Dynamic Brush Menus" addon.Oct 21 2020, 4:32 PM
Ivan Perevala (ivpe) edited the summary of this revision. (Show Details)
Ivan Perevala (ivpe) added a reviewer: Ryan Inch (Imaginer).Oct 21 2020, 9:36 PM
Ryan Inch (Imaginer) accepted this revision.Oct 24 2020, 4:05 AM

LGTM

This revision is now accepted and ready to land.Oct 24 2020, 4:05 AM
Dalai Felinto (dfelinto) added 1 blocking reviewer(s): Jeroen Bakker (jbakker).Mar 26 2021, 5:45 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

This patch has an approved status however it was not committed yet. So I'm assuming the other reviewers are blocking. Updating the reviewers list to reflect this. This way the patch status still show as Need Review.

This revision now requires review to proceed.Mar 26 2021, 5:45 PM
Jeroen Bakker (jbakker) accepted this revision.Mar 27 2021, 2:46 PM
This revision is now accepted and ready to land.Mar 27 2021, 2:46 PM
Ryan Inch (Imaginer) closed this revision.EditedApr 11 2022, 9:34 AM
Ryan Inch (Imaginer) added a subscriber: Campbell Barton (campbellbarton).

I came across this again recently and upon further investigation I'm closing this because an equivalent commit (rBA4599d5d3c8ae91e958fad44df6d5fb30a2edb680) has already been made by @Campbell Barton (campbellbarton).
@Ivan Perevala (ivpe) Thank you for your time and effort and I'm very sorry about this. Your code was good and your patch was/is appreciated, but at the time I wasn't very experienced with Blender's patch management and I was caught up with another add-on, so I really dropped the ball on this one.

Revision Contents
Changeset List

PathSize
space_view3d_brush_menus/
28 lines

Diff 30227

View Options

space_view3d_brush_menus/texture_menu.py

Loading...