Page MenuHome
Differential D929

Beautify polyfill2d code, needed to fix an error running beautify after triangulation: T42630
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Dec 9 2014, 12:27 PM.

Details

Reviewers
Bastien Montagne (mont29)

Diff Detail

Repository
rB Blender
Branch
temp-polyfill2d_arc

Event Timeline

Campbell Barton (campbellbarton) updated this revision to Diff 2984.Dec 9 2014, 12:27 PM
Campbell Barton (campbellbarton) retitled this revision from to Beautify polyfill2d code, needed to fix an error running beautify after triangulation: T42630.
Campbell Barton (campbellbarton) updated this object.
Campbell Barton (campbellbarton) added a reviewer: Bastien Montagne (mont29).
Campbell Barton (campbellbarton) updated this revision to Diff 2985.Dec 9 2014, 12:33 PM
  • minor tweaks, also dont run validation code in release
Campbell Barton (campbellbarton) mentioned this in T42630: 3d print toolbox traceback error.Dec 9 2014, 12:49 PM
Bastien Montagne (mont29) accepted this revision.Dec 9 2014, 1:03 PM
Bastien Montagne (mont29) edited edge metadata.

Patch looks OK to me, only found a (very minor) glitch noted below.

source/blender/blenlib/intern/polyfill2d_beautify.c
436

Look that this is not needed, since it's set anyway just below (line 451)?

This revision is now accepted and ready to land.Dec 9 2014, 1:03 PM
Campbell Barton (campbellbarton) abandoned this revision.Dec 9 2014, 2:09 PM

committed rBa5c3de2e49ca348479b1f5915db9f7460422d07a

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
39 lines
2 lines
intern/
492 lines
bmesh/
intern/
7 lines
82 lines
tools/
41 lines

Diff 2985

View Options

source/blender/blenlib/BLI_polyfill2d_beautify.h

Loading...
View Options

source/blender/blenlib/CMakeLists.txt

Loading...
View Options

source/blender/blenlib/intern/polyfill2d_beautify.c

Loading...
View Options

source/blender/bmesh/intern/bmesh_polygon.h

Loading...
View Options

source/blender/bmesh/intern/bmesh_polygon.c

Loading...
View Options

source/blender/bmesh/tools/bmesh_triangulate.c

Loading...