Page MenuHome
Differential D9303

Fix T81904: Cloth brush simulation failing with local area and mirror
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 21 2020, 7:53 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T81904: Bug sculpting with cloth brush and mirror
Commits
rB31629c1363cc: Fix T81904: Cloth brush simulation failing with local area and mirror
Summary

When using local area, all nodes need to build their constraints first
before activating them for simulation. THis ensures that nodes get their
structural constraints from the initial location of each symmetry pass.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 21 2020, 7:53 PM
Harbormaster completed remote builds in B10859: Diff 30239.Oct 21 2020, 7:53 PM
Pablo Dobarro (pablodp606) requested review of this revision.Oct 21 2020, 7:53 PM
Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Oct 21 2020, 7:53 PM
Sergey Sharybin (sergey) added inline comments.Oct 22 2020, 10:30 AM
source/blender/editors/sculpt_paint/sculpt_cloth.c
1171

Double negation. Suggestion:

This allows to skip unnecessary constraints that will never be simulated
1174

Can you explain why is it so?

Pablo Dobarro (pablodp606) updated this revision to Diff 30289.Oct 23 2020, 2:20 AM
Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • update comment
Harbormaster completed remote builds in B10877: Diff 30289.Oct 23 2020, 2:21 AM
Sergey Sharybin (sergey) accepted this revision.Oct 23 2020, 12:32 PM
This revision is now accepted and ready to land.Oct 23 2020, 12:32 PM
Closed by commit rB31629c1363cc: Fix T81904: Cloth brush simulation failing with local area and mirror (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 25 2020, 11:07 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB31629c1363cc: Fix T81904: Cloth brush simulation failing with local area and mirror.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
37 lines

Diff 30353

View Options

source/blender/editors/sculpt_paint/sculpt_cloth.c

Loading...