Fix T81932: Dyntopo crashing with sculpt vertex colors brush tools
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 21 2020, 10:54 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T81932: Blender crashes after trying to use the smear brush while Dyntopo is enabled

Commits

rBb5169cd2301a: Fix T81932: Dyntopo crashing with sculpt vertex colors brush tools

Summary

Paint and smear tools are only implemented for regular mesh PBVH,
meaning they are not supported by the dynamic topology and multires
sculpting.

These tools are to be ignored for an unsupported sculpt modes, regardless
of state of user preferences.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Oct 21 2020, 10:54 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B10864: Diff 30250.Oct 21 2020, 10:54 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Oct 21 2020, 10:54 PM

The code seems fine. The description can become more useful:

Fix T81932: Dyntopo crashing with sculpt vertex colors brush tools

Paint and smear tools are only implemented for regular mesh PBVH,
meaning they are not supported by the dynamic topology and multires
sculpting.

These tools are to be ignored for an unsupported sculpt modes, regardless
of state of user preferences.

Note that This requires a context, which is not explicitly defined in the original commit message.

This revision is now accepted and ready to land.Oct 22 2020, 10:49 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 22 2020, 6:21 PM

Closed by commit rBb5169cd2301a: Fix T81932: Dyntopo crashing with sculpt vertex colors brush tools (authored by Pablo Dobarro (pablodp606)). · Explain WhyOct 22 2020, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBb5169cd2301a: Fix T81932: Dyntopo crashing with sculpt vertex colors brush tools.