Page MenuHome

Fix typo in Bevel Modifier documentation
AbandonedPublic

Authored by Zeal Wierslee (zealws) on Oct 22 2020, 5:55 AM.

Details

Summary

For the Angle Limit Method, the documentation mistakenly says angles *smaller* than the provided angle will be beveled when in fact angles *greater* than the provided angle are beveled.

See also T81945

Diff Detail

Repository
rBM Blender Manual

Event Timeline

Technically, "greater" is more correct, but from the user's point of view, sharper means a smaller angle.
I would try to rewrite it to take both points of view into account.

Aaron Carlisle (Blendify) requested changes to this revision.Oct 26 2020, 5:30 PM
This revision now requires changes to proceed.Oct 26 2020, 5:30 PM

Looked into this and the comparison is: adjacent angle + defined angle <= 180 degrees


I made an improvement to this in rBM7476

@Aaron Carlisle (Blendify) - here we simply mean the angle between face normals, you can see its value when enabling "Edge Angle" in Overlays.

float no[3];  /* face normal */

const float threshold = cosf(bmd->bevel_angle + 0.000000175f);

if (dot_v3v3(l_a->f->no, l_b->f->no) < threshold) {

Thanks for the clarification, the documentation can be updated to reflect that should be the angle between the face normals.

The tooltip could also be expanded here to better convey this information.

Updated in rBM8485

That looks good to me, thanks for updating the docs :)