Page MenuHome
Differential D9312

break up graph_edit.c
ClosedPublic
Actions

Authored by Christoph Lendenfeld (ChrisLend) on Oct 22 2020, 1:12 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Group Reviewers
Animation & Rigging
Maniphest Tasks
T81785: Implementation: Modal Key Manipulation Operators
Commits
rB1f09dcc121ab: Cleanup: Animation, split `graph_edit.c` into separate files
Summary

Cleanup Phase 1

>>D9312<< D9313

The file editors/space_graph/graph_edit.c has reached ~3600 lines.
Here is a quick overview what it includes:

  • set range extents, preview range
  • ghosting fcurves
  • keyframe manipulations (insert, copy&paste, duplicate, delete)
  • the decimate modal operator
  • baking and sampling (including sound)
  • setting keyframe interpolation
  • keyframe and cursor snapping
  • mirroring keyframes
  • fcurve modifiers
  • drivers

This patch splits off two files

  • graph_view.c: preview range, view all, view selected etc. Think about also including functions from graph_ops.c that do similar things
  • move the decimate modal operator into graph_slider_ops.c. A new file suggested in the parent task.

Diff Detail

Repository
rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.Oct 22 2020, 1:12 PM
Christoph Lendenfeld (ChrisLend) created this revision.
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)
Christoph Lendenfeld (ChrisLend) mentioned this in T81796: break up graph_edit.c.
Christoph Lendenfeld (ChrisLend) mentioned this in T81785: Implementation: Modal Key Manipulation Operators.Oct 22 2020, 1:15 PM
Christoph Lendenfeld (ChrisLend) added a task: T81785: Implementation: Modal Key Manipulation Operators.
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)Oct 22 2020, 3:59 PM
Christoph Lendenfeld (ChrisLend) mentioned this in D9313: create ed_draw.c.
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 31093.Nov 15 2020, 9:35 PM

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2020, 3:28 PM
Closed by commit rB1f09dcc121ab: Cleanup: Animation, split `graph_edit.c` into separate files (authored by Christoph Lendenfeld (ChrisLend), committed by Sybren A. Stüvel (sybren)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB1f09dcc121ab: Cleanup: Animation, split `graph_edit.c` into separate files.
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).Nov 23 2020, 3:29 PM

I have committed the patch in a slightly modified form:

  • Brought back some comment cleanups that were rolled back (so cleaned-up comments were removed from graph_edit.c, and pre-cleanup versions of those comments were added in graph_slider_ops.c).
  • Removed some no-longer-necessary #includes from the new files.
  • Updated the copyright to 2020. I wasn't entirely sure about this, but I think the policy is to set the year to "now" whenever new files are created.
Sybren A. Stüvel (sybren) reopened this revision.Nov 23 2020, 3:29 PM
Sybren A. Stüvel (sybren) accepted this revision.
Sybren A. Stüvel (sybren) added a reviewer: Sybren A. Stüvel (sybren).
This revision is now accepted and ready to land.Nov 23 2020, 3:29 PM
Sybren A. Stüvel (sybren) closed this revision.Nov 23 2020, 3:30 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_graph/
2 lines
973 lines
526 lines
536 lines

Diff 31304

View Options

source/blender/editors/space_graph/CMakeLists.txt

Loading...
View Options

source/blender/editors/space_graph/graph_edit.c

Loading...
View Options

source/blender/editors/space_graph/graph_slider_ops.c

Loading...
View Options

source/blender/editors/space_graph/graph_view.c

Loading...