Page MenuHome
Differential D9336

Fix T81884, clamping with percent, addendum.
ClosedPublic
Actions

Authored by Howard Trickey (howardt) on Oct 24 2020, 4:49 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rB574d711008ab: Fix T81884, clamping with percent, addendum.
Summary

The previous fix forgot the case where there is an intermediate
edge and everything isn't in one plane.

Diff Detail

Repository
rB Blender
Branch
percentclamp (branched from master)
Build Status
Buildable 10900
Build 10900: arc lint + arc unit

Event Timeline

Howard Trickey (howardt) requested review of this revision.Oct 24 2020, 4:49 PM
Howard Trickey (howardt) created this revision.
Harbormaster completed remote builds in B10900: Diff 30328.Oct 24 2020, 4:49 PM
Howard Trickey (howardt) mentioned this in T81884: Bevel modifier width type "percent".Oct 24 2020, 4:51 PM
Hans Goudey (HooglyBoogly) accepted this revision.Oct 24 2020, 8:35 PM

I can confirm this fixes the bug, and it seems relatively straightforward. Actually it seems a bit odd that percent mode made it so long without changes to offset_on_edge_between.

source/blender/bmesh/tools/bmesh_bevel.c
1540–1541

I guess it's too bad that we still have to run these functions in this special case just to get the angle. But the logic to get the angle is pretty wrapped up in the other logic of offset_meet_edge, so it's probably not worth changing that.

This revision is now accepted and ready to land.Oct 24 2020, 8:35 PM
Closed by commit rB574d711008ab: Fix T81884, clamping with percent, addendum. (authored by Howard Trickey (howardt)). · Explain WhyOct 24 2020, 8:47 PM
This revision was automatically updated to reflect the committed changes.
Howard Trickey (howardt) added a commit: rB574d711008ab: Fix T81884, clamping with percent, addendum..

Revision Contents
Changeset List

PathSize
source/
blender/
bmesh/
tools/
33 lines

Diff 30328

View Options

source/blender/bmesh/tools/bmesh_bevel.c

Loading...