Page MenuHome
Differential D9345

Bugfix T81951 - Add Cube new tool surface snaping not working
ClosedPublic
Actions

Authored by Janusch Patas (patjan) on Oct 25 2020, 11:48 PM.

Details

Reviewers
Germano Cavalcante (mano-wii)
Group Reviewers
Modeling
Maniphest Tasks
T81951: Add Cube new tool surface snaping not working
Commits
rB23614c49e945: Fix T81951: Add Cube new tool surface snaping not working
Summary

This is a proposal for the bug mentioned in T81951.
There was no SnapObjectContext available when the gizmo is turned off.

Diff Detail

Repository
rB Blender
Branch
T81951 (branched from master)
Build Status
Buildable 11091
Build 11091: arc lint + arc unit

Event Timeline

Janusch Patas (patjan) created this revision.Oct 25 2020, 11:48 PM
Harbormaster completed remote builds in B10909: Diff 30354.Oct 25 2020, 11:48 PM
Janusch Patas (patjan) requested review of this revision.Oct 25 2020, 11:48 PM
Janusch Patas (patjan) updated this revision to Diff 30355.Oct 25 2020, 11:53 PM

Comment added

Harbormaster completed remote builds in B10910: Diff 30355.Oct 25 2020, 11:53 PM
Janusch Patas (patjan) edited the summary of this revision. (Show Details)Oct 25 2020, 11:56 PM
Janusch Patas (patjan) added a reviewer: Modeling.
Janusch Patas (patjan) added a project: Modeling.
Germano Cavalcante (mano-wii) requested changes to this revision.Nov 2 2020, 8:29 PM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

Thanks for the patch, but the snap_context needs to be freed, which is not seen here.
This results in a memory leak :\

This revision now requires changes to proceed.Nov 2 2020, 8:29 PM
Janusch Patas (patjan) added a comment.Nov 3 2020, 3:40 PM

Thank you Germano. I gonna correct this tonight after work.

Janusch Patas (patjan) updated this revision to Diff 30691.Nov 4 2020, 12:06 AM
  • SnapObjectContext allocated memory delete code included.
Harbormaster completed remote builds in B11091: Diff 30691.Nov 4 2020, 12:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 10 2020, 4:19 PM
Closed by commit rB23614c49e945: Fix T81951: Add Cube new tool surface snaping not working (authored by Germano Cavalcante (mano-wii)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB23614c49e945: Fix T81951: Add Cube new tool surface snaping not working.
Germano Cavalcante (mano-wii) added a comment.Nov 10 2020, 4:22 PM

Thanks for the patch.
Committed a fix with some small changes.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_view3d/
19 lines

Diff 30691

View Options

source/blender/editors/space_view3d/view3d_placement.c

Loading...