Fix T81844: Change Bone Layers fails in Pose Mode
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Oct 26 2020, 10:36 PM.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rB4975aa410cf0: Fix T81844: Change Bone Layers fails in Pose Mode

Summary

When selecting multiple layers, the redo operator might trash the pose data.
To make sure it is in a good state we have to ensure that the pose data is good.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Oct 26 2020, 10:36 PM

Sebastian Parborg (zeddb) created this revision.

Bastien Montagne (mont29) requested changes to this revision.Oct 27 2020, 10:12 AM

Bastien Montagne (mont29) added inline comments.

source/blender/editors/armature/pose_edit.c
901	`Make sure that the pose bone data is up to date (may not always be the case after undo/redo e.g.).` pose bone data is not corrupted, it just needs to be updated.
907	Think you should pass in `bmain` here as well, we want to deg-tag properly rebuilt objects imho.

This revision now requires changes to proceed.Oct 27 2020, 10:12 AM

Sebastian Parborg (zeddb) added inline comments.Oct 27 2020, 12:20 PM

source/blender/editors/armature/pose_edit.c
907	But we tag them of depsgraph updates already on line 920. Do you want me to tag it twice then?

Bastien Montagne (mont29) added inline comments.Oct 27 2020, 12:22 PM

source/blender/editors/armature/pose_edit.c
907	You should not assume some future tagging will cover the one you need here, this is bad and easy source of bugs. And extra tagging costs virtually nothing.