Page MenuHome
Differential D9358

CustomData color copying: use interpolated alpha
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 27 2020, 2:06 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Bastien Montagne (mont29)
Maniphest Tasks
T81914: Data Transfer modifier works inconsistently when dealing with Vertex Color Alpha
Commits
rB3fc97727df6d: CustomData color copying: use interpolated alpha
Summary

For some (unknown) reason, the alpha of the first layer was always used
here [whereas the rgb was interpolated], see rBee4453f08369.

Now also use the interpolated alpha.

thx @Brecht Van Lommel (brecht) noticing!

Meant to be used with D9357

ref T81914

Diff Detail

Repository
rB Blender
Branch
customdata_copy_colors_alpha (branched from master)
Build Status
Buildable 10934
Build 10934: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 27 2020, 2:06 PM
Harbormaster completed remote builds in B10934: Diff 30400.Oct 27 2020, 2:06 PM
Philipp Oeser (lichtwerk) requested review of this revision.Oct 27 2020, 2:06 PM
Philipp Oeser (lichtwerk) mentioned this in D9357: Fix blend_color_interpolate_byte returning wrong alpha in certain case.Oct 27 2020, 2:09 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 27 2020, 2:37 PM
This revision is now accepted and ready to land.Oct 27 2020, 2:37 PM
Bastien Montagne (mont29) accepted this revision.Oct 27 2020, 3:48 PM

Note that when that interpolation code for cdlayers was added vcol did not support any kind of alpha channel, this was added fairly recently (cannot remember when exactly, but think it was for 2.80, in 2019 or something). Guess cdlayer interpolation code was not updated at that point.

Closed by commit rB3fc97727df6d: CustomData color copying: use interpolated alpha (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 29 2020, 9:45 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB3fc97727df6d: CustomData color copying: use interpolated alpha.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
9 lines

Diff 30400

View Options

source/blender/blenkernel/intern/customdata.c

Loading...