Page MenuHome
Differential D9359

GPencil: Improve join operator
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Oct 27 2020, 3:12 PM.

Details

Reviewers
Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)
Maniphest Tasks
T82225: GPencil: Improve Join operator
Commits
rB21f201e25e70: GPencil: Improve join operator
Summary

Now the strokes join the points using the distance bertween the extremes of the strokes and not the order of stroke creation.

No external changes to the operator, only algorithm.

Diff Detail

Repository
rB Blender
Branch
R292-better-join (branched from master)
Build Status
Buildable 10937
Build 10937: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Oct 27 2020, 3:12 PM
Antonio Vazquez (antoniov) created this revision.
Harbormaster completed remote builds in B10937: Diff 30405.Oct 27 2020, 3:12 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Oct 27 2020, 3:15 PM
Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).
Antonio Vazquez (antoniov) added a project: Grease Pencil.
Antonio Vazquez (antoniov) updated this revision to Diff 30407.Oct 27 2020, 3:18 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
  • Fix changes by error with Editor refactor
Harbormaster completed remote builds in B10938: Diff 30407.Oct 27 2020, 3:18 PM
Antonio Vazquez (antoniov) updated this revision to Diff 30499.Oct 29 2020, 3:59 PM
  • Fix bug in distance calculation
Harbormaster completed remote builds in B10978: Diff 30499.Oct 29 2020, 3:59 PM
Antonio Vazquez (antoniov) added a task: T82225: GPencil: Improve Join operator.Oct 29 2020, 5:12 PM
Matias Mendiola (mendio) accepted this revision.Oct 29 2020, 8:04 PM
This revision is now accepted and ready to land.Oct 29 2020, 8:04 PM
Closed by commit rB21f201e25e70: GPencil: Improve join operator (authored by Antonio Vazquez (antoniov)). · Explain WhyOct 29 2020, 8:15 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB21f201e25e70: GPencil: Improve join operator.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
323 lines

Diff 30405

View Options

source/blender/editors/gpencil/gpencil_edit.c

Loading...